linux-kernel - RE: [PATCH v1] mmc-utils: Add General command CMD56 read support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR04MB65758A57DBA5BE8A33578BE9FCEA9@DM6PR04MB6575.namprd04.prod.outlook.com>
Date:   Mon, 11 Apr 2022 10:04:40 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     Bean Huo <huobean@...il.com>,
        "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
        "adrian.hunter@...el.com" <adrian.hunter@...el.com>
CC:     "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jakob.rossler@...ia.com" <jakob.rossler@...ia.com>,
        "sperson@...ron.com" <sperson@...ron.com>,
        Bean Huo <beanhuo@...ron.com>
Subject: RE: [PATCH v1] mmc-utils: Add General command CMD56 read support

> On Sat, 2022-04-09 at 09:03 +0000, Avri Altman wrote:
> > > +       memset(&idata, 0, sizeof(idata));
> > > +       idata.write_flag = 0;
> > > +       idata.opcode = MMC_GEN_CMD;
> > > +       idata.arg = arg;
> > Practically arg is not needed, because bits[1..31] are meaningless.
> > Maybe just set: idata.arg = 1;
> >
> > Thanks,
> > Avri
> Thanks for your review.
> 
> you are right arg is not needed according to eMMC spec.  But as I mentioned
> in the commit message, for the universal use. we need it for the vendor-
> specific arg. I will change it that its arg will be 1 by default if the user doesn't
> specific arg.
Ack.

Thanks,
Avri

> 
> Kind regards,
> Bean
> 
>