linux-kernel - RE: [PATCH v1] mmc-utils: Add General command CMD56 read support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <HE1PR0702MB3579F880543CE671E40725FBF2EF9@HE1PR0702MB3579.eurprd07.prod.outlook.com>
Date:   Thu, 14 Apr 2022 10:38:23 +0000
From:   "Rossler, Jakob (Nokia - DE/Ulm)" <jakob.rossler@...ia.com>
To:     Avri Altman <Avri.Altman@....com>, Bean Huo <huobean@...il.com>,
        "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
        "adrian.hunter@...el.com" <adrian.hunter@...el.com>
CC:     "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "sperson@...ron.com" <sperson@...ron.com>,
        Bean Huo <beanhuo@...ron.com>
Subject: RE: [PATCH v1] mmc-utils: Add General command CMD56 read support

Tested-by: Rossler, Jakob (Nokia - DE/Ulm) <jakob.rossler@...ia.com>

Best regards
Jakob

-----Original Message-----
From: Avri Altman <Avri.Altman@....com> 
Sent: Monday, April 11, 2022 12:05 PM
To: Bean Huo <huobean@...il.com>; ulf.hansson@...aro.org; adrian.hunter@...el.com
Cc: linux-mmc@...r.kernel.org; linux-kernel@...r.kernel.org; Rossler, Jakob (Nokia - DE/Ulm) <jakob.rossler@...ia.com>; sperson@...ron.com; Bean Huo <beanhuo@...ron.com>
Subject: RE: [PATCH v1] mmc-utils: Add General command CMD56 read support

> On Sat, 2022-04-09 at 09:03 +0000, Avri Altman wrote:
> > > +       memset(&idata, 0, sizeof(idata));
> > > +       idata.write_flag = 0;
> > > +       idata.opcode = MMC_GEN_CMD;
> > > +       idata.arg = arg;
> > Practically arg is not needed, because bits[1..31] are meaningless.
> > Maybe just set: idata.arg = 1;
> >
> > Thanks,
> > Avri
> Thanks for your review.
> 
> you are right arg is not needed according to eMMC spec.  But as I 
> mentioned in the commit message, for the universal use. we need it for 
> the vendor- specific arg. I will change it that its arg will be 1 by 
> default if the user doesn't specific arg.
Ack.

Thanks,
Avri

> 
> Kind regards,
> Bean
> 
>