linux-kernel - Re: [PATCH v2 3/3] cpufreq: CPPC: Register EM based on efficiency class information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7e6c2393-8e24-2755-f3c7-16764f700880@arm.com>
Date:   Mon, 11 Apr 2022 12:33:08 +0200
From:   Pierre Gondois <pierre.gondois@....com>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     linux-kernel@...r.kernel.org, Ionela.Voinescu@....com,
        Lukasz.Luba@....com, Morten.Rasmussen@....com,
        Dietmar.Eggemann@....com, maz@...nel.org,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Ard Biesheuvel <ardb@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Fuad Tabba <tabba@...gle.com>,
        Sudeep Holla <sudeep.holla@....com>,
        Rob Herring <robh@...nel.org>,
        Lee Jones <lee.jones@...aro.org>,
        linux-arm-kernel@...ts.infradead.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH v2 3/3] cpufreq: CPPC: Register EM based on efficiency
 class information

Hello Viresh,

On 4/11/22 05:12, Viresh Kumar wrote:
> On 07-04-22, 10:16, Pierre Gondois wrote:
>> +static void cppc_cpufreq_register_em(struct cpufreq_policy *policy)
>> +{
>> +	struct cppc_cpudata *cpu_data;
>> +	struct em_data_callback em_cb =
>> +		EM_ADV_DATA_CB(cppc_get_cpu_power, cppc_get_cpu_cost);
>> +
>> +	if (!efficiency_class_populated)
> 
> Instead of a new variable for this, what about setting
> cppc_cpufreq_driver.register_em = cppc_cpufreq_register_em, only if
> you were able to populate the efficiency class in the first place ?
> 

Yes right, this would be better,
Regards,
Pierre