linux-kernel - Re: [PATCH] drivers: dma: using pm_runtime_resume_and_get instead of pm_runtime_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YlQH/WjgLgD5uVsP@matsya>
Date:   Mon, 11 Apr 2022 16:20:37 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     cgel.zte@...il.com
Cc:     sean.wang@...iatek.com, matthias.bgg@...il.com,
        dmaengine@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Minghao Chi <chi.minghao@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] drivers: dma: using pm_runtime_resume_and_get instead of
 pm_runtime_get_sync

On 11-04-22, 01:35, cgel.zte@...il.com wrote:
> From: Minghao Chi <chi.minghao@....com.cn>

subsystem tag is wrong, pls see gitlog to find the appropriate one

> 
> Using pm_runtime_resume_and_get is more appropriate
> for simplifing code

Can you explain why it is appropriate?

> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@....com.cn>
> ---
>  drivers/dma/mediatek/mtk-uart-apdma.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/dma/mediatek/mtk-uart-apdma.c b/drivers/dma/mediatek/mtk-uart-apdma.c
> index 375e7e647df6..64bad5681447 100644
> --- a/drivers/dma/mediatek/mtk-uart-apdma.c
> +++ b/drivers/dma/mediatek/mtk-uart-apdma.c
> @@ -274,11 +274,9 @@ static int mtk_uart_apdma_alloc_chan_resources(struct dma_chan *chan)
>  	unsigned int status;
>  	int ret;
>  
> -	ret = pm_runtime_get_sync(mtkd->ddev.dev);
> -	if (ret < 0) {
> -		pm_runtime_put_noidle(chan->device->dev);
> +	ret = pm_runtime_resume_and_get(mtkd->ddev.dev);
> +	if (ret < 0)
>  		return ret;
> -	}
>  
>  	mtk_uart_apdma_write(c, VFF_ADDR, 0);
>  	mtk_uart_apdma_write(c, VFF_THRE, 0);
> -- 
> 2.25.1

-- 
~Vinod