linux-kernel - Re: [PATCH v4] libata: Improve ATA queued command allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <58553b08-3c58-a4c8-a402-26d036ef0640@opensource.wdc.com>
Date:   Mon, 11 Apr 2022 21:26:18 +0900
From:   Damien Le Moal <damien.lemoal@...nsource.wdc.com>
To:     John Garry <john.garry@...wei.com>, hch@....de
Cc:     linux-doc@...r.kernel.org, linux-ide@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] libata: Improve ATA queued command allocation

On 4/8/22 18:04, John Garry wrote:
> Improve ATA queued command allocation as follows:
> 
> - For attaining a qc tag for a SAS host we need to allocate a bit in
>   ata_port.sas_tag_allocated bitmap.
> 
>   However we already have a unique tag per device in range
>   [0, ATA_MAX_QUEUE -1] in the scsi cmnd budget token, so just use that
>   instead.
> 
> - It is a bit pointless to have ata_qc_new_init() in libata-core.c since it
>   pokes scsi internals, so inline it in ata_scsi_qc_new() (in
>   libata-scsi.c). Also update Doc accordingly.
> 
> - Use standard SCSI helpers set_host_byte() and set_status_byte() in
>   ata_scsi_qc_new().
> 
> Christoph Hellwig originally contributed the change to inline
> ata_qc_new_init().
> 
> Signed-off-by: John Garry <john.garry@...wei.com>
> Reviewed-by: Christoph Hellwig <hch@....de>

Applied to for-5.19. Thanks !

-- 
Damien Le Moal
Western Digital Research