linux-kernel - Re: [PATCH v8 03/20] cachefiles: notify user daemon with anon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Apr 2022 20:36:05 +0800
From:   JeffleXu <jefflexu@...ux.alibaba.com>
To:     David Howells <dhowells@...hat.com>
Cc:     linux-cachefs@...hat.com, xiang@...nel.org, chao@...nel.org,
        linux-erofs@...ts.ozlabs.org, torvalds@...ux-foundation.org,
        gregkh@...uxfoundation.org, willy@...radead.org,
        linux-fsdevel@...r.kernel.org, joseph.qi@...ux.alibaba.com,
        bo.liu@...ux.alibaba.com, tao.peng@...ux.alibaba.com,
        gerry@...ux.alibaba.com, eguan@...ux.alibaba.com,
        linux-kernel@...r.kernel.org, luodaowen.backend@...edance.com,
        tianzichen@...ishou.com, fannaihao@...du.com
Subject: Re: [PATCH v8 03/20] cachefiles: notify user daemon with anon_fd when
 looking up cookie



On 4/11/22 8:28 PM, David Howells wrote:
> Jeffle Xu <jefflexu@...ux.alibaba.com> wrote:
> 
>> +	  This permits on-demand read mode of cachefiles. In this mode, when
>> +	  cache miss, the cachefiles backend instead of netfs, is responsible
>> +          for fetching data, e.g. through user daemon.
> 
> That third line should probably begin with a tab as the other two line do.

Oh yeah...

> 
>> +static inline void cachefiles_flush_reqs(struct cachefiles_cache *cache)
> 
> If it's in a .c file, there's no need to mark it "inline".  The compiler will
> inline it anyway if it decides it should.

Okay.

> 
>> +#ifdef CONFIG_CACHEFILES_ONDEMAND
>> +	cachefiles_flush_reqs(cache);
>> +	xa_destroy(&cache->reqs);
>> +#endif
> 
> If cachefiles_flush_reqs() is only used in this one place, the xa_destroy()
> should possibly be moved into it.
> 

Alright.


-- 
Thanks,
Jeffle