linux-kernel - Re: [PATCH] mm/slub: remove meaningless node check in ___slab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMZfGtXH_AdzSea6eTJk==LQXB40iN0wFP6cry8=OpDGgY0dtg@mail.gmail.com>
Date:   Mon, 11 Apr 2022 11:50:14 +0800
From:   Muchun Song <songmuchun@...edance.com>
To:     JaeSang Yoo <js.yoo.5b@...il.com>
Cc:     Christoph Lameter <cl@...ux.com>,
        Pekka Enberg <penberg@...nel.org>,
        David Rientjes <rientjes@...gle.com>,
        Joonsoo Kim <iamjoonsoo.kim@....com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Vlastimil Babka <vbabka@...e.cz>,
        Roman Gushchin <roman.gushchin@...ux.dev>,
        Ohhoon Kwon <ohkwon1043@...il.com>,
        Wonhyuk Yang <vvghjk1234@...il.com>,
        Jiyoup Kim <lakroforce@...il.com>,
        Donghyeok Kim <dthex5d@...il.com>,
        JaeSang Yoo <jsyoo5b@...il.com>,
        Linux Memory Management List <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm/slub: remove meaningless node check in ___slab_alloc()

On Sat, Apr 9, 2022 at 10:43 PM JaeSang Yoo <js.yoo.5b@...il.com> wrote:
>
> node_match() with node=NUMA_NO_NODE always returns 1.
> Duplicate check by goto statement is meaningless. Remove it.
>
> Signed-off-by: JaeSang Yoo <jsyoo5b@...il.com>

LGTM.

Reviewed-by: Muchun Song <songmuchun@...edance.com>