linux-kernel - Re: [PATCH] ixp4xx_eth: fix error check return value of platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdY87j7-Gm6fPM_MXBZvLsHWCPVU3gdbv1b=vB+L-Mn5QA@mail.gmail.com>
Date:   Tue, 12 Apr 2022 15:45:21 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     cgel.zte@...il.com
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        arnd@...db.de, lv.ruyi@....com.cn, wanjiabing@...o.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] ixp4xx_eth: fix error check return value of platform_get_irq()

On Tue, Apr 12, 2022 at 10:51 AM <cgel.zte@...il.com> wrote:

> From: Lv Ruyi <lv.ruyi@....com.cn>
>
> platform_get_irq() return negative value on failure, so null check of
> return value is incorrect. Fix it by comparing whether it is less than
> zero.
>
> Fixes: 9055a2f59162 ("ixp4xx_eth: make ptp support a platform driver")
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@....com.cn>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij