linux-kernel - Re: [PATCH] mfd: fix error check return value of platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Apr 2022 15:46:14 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     cgel.zte@...il.com
Cc:     lee.jones@...aro.org, gremlin@...mlin.it,
        gregkh@...uxfoundation.org, mad_soft@...ox.ru,
        linux-kernel@...r.kernel.org, Lv Ruyi <lv.ruyi@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] mfd: fix error check return value of platform_get_irq()

On Tue, Apr 12, 2022 at 10:53 AM <cgel.zte@...il.com> wrote:

> From: Lv Ruyi <lv.ruyi@....com.cn>
>
> platform_get_irq() return negative value on failure, so null check of
> irq is incorrect. Fix it by comparing whether it is less than zero.
>
> Fixes: dcc21cc09e3c ("mfd: Add driver for Atmel Microcontroller on iPaq h3xxx")
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@....com.cn>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij