linux-kernel - Re: [PATCH v2] spi: cadence-quadspi: fix incorrect supports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <164987137835.70105.4695547877202856949.b4-ty@kernel.org>
Date:   Wed, 13 Apr 2022 18:36:18 +0100
From:   Mark Brown <broonie@...nel.org>
To:     p.yadav@...com, matthias.schiffer@...tq-group.com
Cc:     tudor.ambarus@...rochip.com, linux-kernel@...r.kernel.org,
        vigneshr@...com, vadivel.muruganx.ramuthevar@...ux.intel.com,
        linux-spi@...r.kernel.org
Subject: Re: [PATCH v2] spi: cadence-quadspi: fix incorrect supports_op() return value

On Wed, 6 Apr 2022 15:28:32 +0200, Matthias Schiffer wrote:
> Since the conversion to spi-mem, the driver advertised support for
> various operations that cqspi_set_protocol() was never expected to handle
> correctly - in particuar all non-DTR operations with command or address
> buswidth > 1. For DTR, all operations except for 8-8-8 would fail, as
> cqspi_set_protocol() returns -EINVAL.
> 
> In non-DTR mode, this resulted in data corruption for SPI-NOR flashes that
> support such operations. As a minimal fix that can be backported to stable
> kernels, simply disallow the unsupported operations again to avoid this
> issue.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: cadence-quadspi: fix incorrect supports_op() return value
      commit: f1d388f216aeb41a5df518815ae559d14a6d438e

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark