linux-kernel - Re: [PATCH v2] spi: cadence-quadspi: fix incorrect supports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 13 Apr 2022 23:41:34 +0530
From:   Pratyush Yadav <p.yadav@...com>
To:     Matthias Schiffer <matthias.schiffer@...tq-group.com>
CC:     Mark Brown <broonie@...nel.org>,
        Tudor Ambarus <tudor.ambarus@...rochip.com>,
        Vignesh Raghavendra <vigneshr@...com>,
        Ramuthevar Vadivel Murugan 
        <vadivel.muruganx.ramuthevar@...ux.intel.com>,
        <linux-spi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] spi: cadence-quadspi: fix incorrect supports_op()
 return value

On 06/04/22 03:28PM, Matthias Schiffer wrote:
> Since the conversion to spi-mem, the driver advertised support for
> various operations that cqspi_set_protocol() was never expected to handle
> correctly - in particuar all non-DTR operations with command or address
> buswidth > 1. For DTR, all operations except for 8-8-8 would fail, as
> cqspi_set_protocol() returns -EINVAL.
> 
> In non-DTR mode, this resulted in data corruption for SPI-NOR flashes that
> support such operations. As a minimal fix that can be backported to stable
> kernels, simply disallow the unsupported operations again to avoid this
> issue.
> 
> Fixes: a314f6367787 ("mtd: spi-nor: Convert cadence-quadspi to use spi-mem framework")
> Signed-off-by: Matthias Schiffer <matthias.schiffer@...tq-group.com>

I suppose it is too late now since the patch is already applied. But 
FWIW,

Reviewed-by: Pratyush Yadav <p.yadav@...com>

-- 
Regards,
Pratyush Yadav
Texas Instruments Inc.