linux-kernel - Re: [PATCH] ARM: dts: BCM5301X: Add DT for Buffalo WZR-1166DHP2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 Apr 2022 22:09:32 +0900
From:   SHIMAMOTO Takayoshi <takayoshi.shimamoto.360@...il.com>
To:     Rafał Miłecki <zajec5@...il.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Hauke Mehrtens <hauke@...ke-m.de>,
        bcm-kernel-feedback-list@...adcom.com,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: BCM5301X: Add DT for Buffalo WZR-1166DHP2


Thank you for the replies.

On 2022/04/13 2:49, Rafał Miłecki wrote:
>>   - 4x 10/100M ethernet switch
> 
> Isn't that 10/100/1000?

You are right.
It supports 10/100/1000Mbps.

>> +    model = "Buffalo WZR-1166DHP2 (BCM4708)";
> 
> We stopped adding SoC name to the "model" value, please drop it.

Understood.

I will fix it as follows
model = "Buffalo WZR-1166DHP2";

>> +
>> +        wireless1 {
>> +            label = "bcm53xx:amber:wireless";
>> +            gpios = <&hc595 7 GPIO_ACTIVE_HIGH>;
>> +        };
>> +    };
> 
> I'm wondering if all new DTS files should use "function" and "color"
> instead of "label". That's preferred solution and I guess it's good idea
> to use it for new code.

Understood.

I will rewrite it with "function" and "color."

I will post the patch again after testing.

Best regards