linux-kernel - Re: [PATCH V3 1/3] drivers: nfc: nfcmrvl: fix double free bugs caused by fw_dnld

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f198a12.102db.180269f7d00.Coremail.linma@zju.edu.cn>
Date:   Thu, 14 Apr 2022 13:50:28 +0800 (GMT+08:00)
From:   "Lin Ma" <linma@....edu.cn>
To:     "Duoming Zhou" <duoming@....edu.cn>
Cc:     krzk@...nel.org, linux-kernel@...r.kernel.org, davem@...emloft.net,
        gregkh@...uxfoundation.org, alexander.deucher@....com,
        akpm@...ux-foundation.org, broonie@...nel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH V3 1/3] drivers: nfc: nfcmrvl: fix double free bugs
 caused by fw_dnld_over()

Hello there,

Sorry here but actually I didn't "review" this patch but only offer some suggestions.
It seems that the current version of patch mainly focus on solving the data race. However, I'd prefer to make sure this function

> static void fw_dnld_over(struct nfcmrvl_private *priv, u32 error)

never be able to be called more than once. Maybe add some additional flag with lock is more appropriate.

Regards
Lin