linux-kernel - Re: [PATCH] crypto: ux500/hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 15 Apr 2022 16:40:46 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Yihao Han <hanyihao@...o.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Julia Lawall <Julia.Lawall@...ia.fr>,
        Linus Walleij <linus.walleij@...aro.org>,
        Zhen Lei <thunder.leizhen@...wei.com>,
        YueHaibing <yuehaibing@...wei.com>, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...o.com
Subject: Re: [PATCH] crypto: ux500/hash - simplify if-if to if-else

On Fri, Apr 08, 2022 at 07:23:49AM -0700, Yihao Han wrote:
> Replace `if (!req_ctx->updated)` with `else` for simplification
> and add curly brackets according to the kernel coding style:
> 
> "Do not unnecessarily use braces where a single statement will do."
> 
> ...
> 
> "This does not apply if only one branch of a conditional statement is
> a single statement; in the latter case use braces in both branches"
> 
> Please refer to:
> https://www.kernel.org/doc/html/v5.17-rc8/process/coding-style.html
> 
> Signed-off-by: Yihao Han <hanyihao@...o.com>
> ---
>  drivers/crypto/ux500/hash/hash_core.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt