linux-kernel - Re: [EXT] [PATCH v6 4/4] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2231070a-85ed-94d3-7467-dcdd8822ad56@pengutronix.de>
Date:   Fri, 15 Apr 2022 22:02:06 +0200
From:   Ahmad Fatoum <a.fatoum@...gutronix.de>
To:     Pankaj Gupta <pankaj.gupta@....com>,
        Jonathan Corbet <corbet@....net>,
        David Howells <dhowells@...hat.com>,
        Jarkko Sakkinen <jarkko@...nel.org>,
        James Bottomley <jejb@...ux.ibm.com>,
        Mimi Zohar <zohar@...ux.ibm.com>
Cc:     "kernel@...gutronix.de" <kernel@...gutronix.de>,
        David Gstir <david@...ma-star.at>,
        "tharvey@...eworks.com" <tharvey@...eworks.com>,
        Matthias Schiffer <matthias.schiffer@...tq-group.com>,
        James Morris <jmorris@...ei.org>,
        "Serge E. Hallyn" <serge@...lyn.com>,
        Horia Geanta <horia.geanta@....com>,
        Aymen Sghaier <aymen.sghaier@....com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Biggers <ebiggers@...nel.org>,
        Jan Luebbe <j.luebbe@...gutronix.de>,
        Richard Weinberger <richard@....at>,
        Franck Lenormand <franck.lenormand@....com>,
        Sumit Garg <sumit.garg@...aro.org>,
        "keyrings@...r.kernel.org" <keyrings@...r.kernel.org>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux-integrity@...r.kernel.org" <linux-integrity@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-security-module@...r.kernel.org" 
        <linux-security-module@...r.kernel.org>
Subject: Re: [EXT] [PATCH v6 4/4] KEYS: trusted: Introduce support for NXP
 CAAM-based trusted keys

Hello Pankaj,

On 28.03.22 12:46, Pankaj Gupta wrote:
> If the structure "struct keyblob_info", is used in patch 3/4, then below use for CAAM specific macros
> will not be needed to be set in this file/function.

Yes, I moved the output size computation into the previous patch.

> If the structure "struct keyblob_info", is used in patch 3/4, then below line of code will not be needed.

It must be set regardless. How else would the trusted key core know how big
the blob is.

> If the structure "struct keyblob_info", is used in patch 3/4, then below line of code will not be needed.
> 
>> +       p->key_len = length - CAAM_BLOB_OVERHEAD;

Likewise.

Cheers,
Ahmad

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |