linux-kernel - Re: [PATCH v7 3/6] crypto: caam - add in-kernel interface for blob generator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4989d998-6ce3-139a-32b5-482234a11b68@pengutronix.de>
Date:   Sun, 17 Apr 2022 20:47:13 +0200
From:   Ahmad Fatoum <a.fatoum@...gutronix.de>
To:     Jarkko Sakkinen <jarkko@...nel.org>,
        Horia Geantă <horia.geanta@....com>,
        Pankaj Gupta <pankaj.gupta@....com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>
Cc:     kernel@...gutronix.de, David Gstir <david@...ma-star.at>,
        Tim Harvey <tharvey@...eworks.com>,
        Matthias Schiffer <matthias.schiffer@...tq-group.com>,
        James Bottomley <jejb@...ux.ibm.com>,
        Mimi Zohar <zohar@...ux.ibm.com>,
        David Howells <dhowells@...hat.com>,
        James Morris <jmorris@...ei.org>,
        Eric Biggers <ebiggers@...nel.org>,
        "Serge E. Hallyn" <serge@...lyn.com>,
        Jan Luebbe <j.luebbe@...gutronix.de>,
        Richard Weinberger <richard@....at>,
        Franck LENORMAND <franck.lenormand@....com>,
        Sumit Garg <sumit.garg@...aro.org>,
        linux-integrity@...r.kernel.org, keyrings@...r.kernel.org,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-security-module@...r.kernel.org
Subject: Re: [PATCH v7 3/6] crypto: caam - add in-kernel interface for blob
 generator

Hello Jarkko,

On 17.04.22 17:02, Jarkko Sakkinen wrote:
> On Fri, 2022-04-15 at 22:56 +0200, Ahmad Fatoum wrote:
>> +int caam_process_blob(struct caam_blob_priv *priv,
>> +                     struct caam_blob_info *info, bool encap)
> 
> Documentation missing (it's exported).

It's documented in the header.

>> +/** struct caam_blob_info - information for CAAM blobbing
>> + *
> 
> You can remove this extra line, applies to some functions in the patch
> too.

You mean the blank line? Ye, that looks like it doesn't matter.
I just ran scripts/kernel-doc and apparently I need a space before
the struct caam_blob_info part, so it's even registered as a kernel doc.

Will fix for v8.
 
> BR, Jarkko

Thanks for the review.

Cheers,
Ahmad


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |