linux-kernel - Re: [PATCH v2 1/6] staging: r8188eu: remove unused member free_bss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a28f445f-f088-620e-6baf-4cad3e1a8146@gmail.com>
Date:   Sun, 17 Apr 2022 23:16:38 +0300
From:   Pavel Skripkin <paskripkin@...il.com>
To:     Jaehee Park <jhpark1013@...il.com>,
        "Fabio M. De Francesco" <fmdefrancesco@...il.com>
Cc:     Larry.Finger@...inger.net, phil@...lpotter.co.uk,
        gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, outreachy@...ts.linux.dev
Subject: Re: [PATCH v2 1/6] staging: r8188eu: remove unused member
 free_bss_buf

Hi Jaehee,

On 4/17/22 23:14, Jaehee Park wrote:
> My understanding of Pavel's response is the free_bss_buf member of the
> pmlmepriv structure wasn't being used anywhere and that the
> rtw_free_mlme_riv_ie_data function frees the memory of the pmlmepriv
> structure so the second check is redundant.
> 
> However, as Fabio said, the free_bss_buf member is being used and pbuf
> memory is not being freed.
> So I'll revert the patch as it was originally (which was just removing
> the {} around the single if statement).
> 

Why just `pbuf` allocation can't be removed? This memory is just unused, 
isn't it?




With regards,
Pavel Skripkin

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)