linux-kernel - Re: [PATCH v2 3/6] staging: r8188eu: remove 'added by' author comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6925e230-b816-ea9a-067f-60cefecd8af7@gmail.com>
Date:   Sun, 17 Apr 2022 23:23:03 +0300
From:   Pavel Skripkin <paskripkin@...il.com>
To:     Jaehee Park <jhpark1013@...il.com>, Larry.Finger@...inger.net
Cc:     phil@...lpotter.co.uk, gregkh@...uxfoundation.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        outreachy@...ts.linux.dev,
        Alison Schofield <alison.schofield@...el.com>
Subject: Re: [PATCH v2 3/6] staging: r8188eu: remove 'added by' author
 comments

Hi Jaehee,

On 4/15/22 05:48, Jaehee Park wrote:
> Author comments "Added by Albert" and "Added by Annie" are sprinkled
> through the file. These comments are not useful and can be removed.
> 
> Reviewed-by: Pavel Skripkin <paskripkin@...il.com>

I don't remember giving that tag, but now I am OK with it, since patch 
looks good

Please, don't put random Reviewed-by tags in your commit message, since 
it's not how Reviewed-by tags work

> Suggested-by: Alison Schofield <alison.schofield@...el.com>
> Signed-off-by: Jaehee Park <jhpark1013@...il.com>




With regards,
Pavel Skripkin