linux-kernel - Re: [RESEND][PATCH v3 1/2] serial: 8250: Fold EndRun device support into OxSemi Tornado code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.2204172339300.9383@angie.orcam.me.uk>
Date:   Mon, 18 Apr 2022 00:02:54 +0100 (BST)
From:   "Maciej W. Rozycki" <macro@...am.me.uk>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
cc:     Jiri Slaby <jirislaby@...nel.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND][PATCH v3 1/2] serial: 8250: Fold EndRun device support
 into OxSemi Tornado code

On Fri, 15 Apr 2022, Greg Kroah-Hartman wrote:

> > Index: linux-macro/include/linux/pci_ids.h
> > ===================================================================
> > --- linux-macro.orig/include/linux/pci_ids.h
> > +++ linux-macro/include/linux/pci_ids.h
> > @@ -2622,6 +2622,9 @@
> >  #define PCI_DEVICE_ID_DCI_PCCOM8	0x0002
> >  #define PCI_DEVICE_ID_DCI_PCCOM2	0x0004
> >  
> > +#define PCI_VENDOR_ID_ENDRUN		0x7401
> > +#define PCI_DEVICE_ID_ENDRUN_1588	0xe100
> 
> As per the top of this file, this should not be needed here as you are
> only using it in one file.  Please leave it as-is.

 I find this requirement silly, but here it's not the place to discuss it, 
so I have removed this part as requested.  At least it's not inline magic 
numbers here.

  Maciej