linux-kernel - Re: [RESEND][PATCH v3 1/2] serial: 8250: Fold EndRun device support into OxSemi Tornado code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.2204172341250.9383@angie.orcam.me.uk>
Date:   Mon, 18 Apr 2022 00:03:00 +0100 (BST)
From:   "Maciej W. Rozycki" <macro@...am.me.uk>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
cc:     Jiri Slaby <jirislaby@...nel.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND][PATCH v3 1/2] serial: 8250: Fold EndRun device support
 into OxSemi Tornado code

On Fri, 15 Apr 2022, Greg Kroah-Hartman wrote:

> > Remove redundant code then and factor out OxSemi Tornado device
> > detection.  Also correct the baud base like with commit 6cbe45d8ac93
> > ("serial: 8250: Correct the clock for OxSemi PCIe devices") for the
> > value of 3906250 rather than 4000000, obtained by dividing the 62.5MHz
> > clock input by the default oversampling rate of 16.  Finally move the
> > EndRun vendor:device ID to <linux/pci_ids.h>.
> 
> That's a lot of different things happening all the same commit.  Please
> break this out into one-patch-per-logical-change as is required.

 The baud base fix is completely swallowed by the next change for EndRun 
devices, but I guess someone may want to backport it on its own, however 
unlikely.

 I have posted v4 then with this change split off (and the other removed) 
as per your request.  I have also reconsidered the changes made in 2/2 and 
split it into three, so that drivers/tty/serial/8250/8250_port.c updates 
are separate and self-contained.

 In the course of the respin, I have realised exporting the ICR access
helpers caused a code generation regression, so I have removed the inline 
function specifier so as to let the compiler choose whether to inline the 
functions or not.  I have also realised that the change to the console 
restorer is actually a fix for a preexisting bug in handling of the AFE 
bit, so I have annotated the change accordingly.

 Thank you for your review.

  Maciej