linux-kernel - Re: [RESEND][PATCH v3 1/2] serial: 8250: Fold EndRun device support into OxSemi Tornado code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YmAdTDkZzdiQNKab@kroah.com>
Date:   Wed, 20 Apr 2022 16:48:44 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     "Maciej W. Rozycki" <macro@...am.me.uk>
Cc:     Jiri Slaby <jirislaby@...nel.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND][PATCH v3 1/2] serial: 8250: Fold EndRun device support
 into OxSemi Tornado code

On Mon, Apr 18, 2022 at 12:02:54AM +0100, Maciej W. Rozycki wrote:
> On Fri, 15 Apr 2022, Greg Kroah-Hartman wrote:
> 
> > > Index: linux-macro/include/linux/pci_ids.h
> > > ===================================================================
> > > --- linux-macro.orig/include/linux/pci_ids.h
> > > +++ linux-macro/include/linux/pci_ids.h
> > > @@ -2622,6 +2622,9 @@
> > >  #define PCI_DEVICE_ID_DCI_PCCOM8	0x0002
> > >  #define PCI_DEVICE_ID_DCI_PCCOM2	0x0004
> > >  
> > > +#define PCI_VENDOR_ID_ENDRUN		0x7401
> > > +#define PCI_DEVICE_ID_ENDRUN_1588	0xe100
> > 
> > As per the top of this file, this should not be needed here as you are
> > only using it in one file.  Please leave it as-is.
> 
>  I find this requirement silly, but here it's not the place to discuss it, 

You have not had to deal with merge issues in this file before.  Think
about every single PCI driver author updating this single file.  That
just does not work at the scale we run at, sorry.  I put this rule into
place 15+ years ago for that reason.

thanks,

greg k-h