linux-kernel - Re: [PATCH] dmaengine: plx_dma: Move spin_lock_bh() to spin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f66e3fc3-ddf8-3223-f94c-dd98e1648a56@deltatee.com>
Date:   Mon, 18 Apr 2022 09:54:22 -0600
From:   Logan Gunthorpe <logang@...tatee.com>
To:     Yunbo Yu <yuyunbo519@...il.com>, vkoul@...nel.org
Cc:     dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: plx_dma: Move spin_lock_bh() to spin_lock()



On 2022-04-18 08:20, Yunbo Yu wrote:
> It is unnecessary to call spin_lock_bh() for you are already in a tasklet.
> 
> Signed-off-by: Yunbo Yu <yuyunbo519@...il.com>

Ah, thanks!

Reviewed-by: Logan Gunthorpe <logang@...tatee.com>

> ---
>  drivers/dma/plx_dma.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/plx_dma.c b/drivers/dma/plx_dma.c
> index 1ffcb5ca9788..12725fa1655f 100644
> --- a/drivers/dma/plx_dma.c
> +++ b/drivers/dma/plx_dma.c
> @@ -137,7 +137,7 @@ static void plx_dma_process_desc(struct plx_dma_dev *plxdev)
>  	struct plx_dma_desc *desc;
>  	u32 flags;
>  
> -	spin_lock_bh(&plxdev->ring_lock);
> +	spin_lock(&plxdev->ring_lock);
>  
>  	while (plxdev->tail != plxdev->head) {
>  		desc = plx_dma_get_desc(plxdev, plxdev->tail);
> @@ -165,7 +165,7 @@ static void plx_dma_process_desc(struct plx_dma_dev *plxdev)
>  		plxdev->tail++;
>  	}
>  
> -	spin_unlock_bh(&plxdev->ring_lock);
> +	spin_unlock(&plxdev->ring_lock);
>  }
>  
>  static void plx_dma_abort_desc(struct plx_dma_dev *plxdev)