linux-kernel - Re: [PATCH] EDAC/dmc520: Don't print an error for each unconfigured interrupt line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yl3UgPtVV3t4pzVe@zn.tnic>
Date:   Mon, 18 Apr 2022 23:13:36 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Tyler Hicks <tyhicks@...ux.microsoft.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Sasha Levin <sashal@...nel.org>, Lei Wang <lewan@...rosoft.com>,
        Tony Luck <tony.luck@...el.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Sinan Kaya <okaya@...nel.org>,
        Shiping Ji <shiping.linux@...il.com>,
        James Morse <james.morse@....com>,
        Robert Richter <rric@...nel.org>, linux-edac@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] EDAC/dmc520: Don't print an error for each unconfigured
 interrupt line

On Mon, Apr 18, 2022 at 03:40:29PM -0500, Tyler Hicks wrote:
> > The API argument seems to have fizzled out in v2:
> > 
> >  https://lore.kernel.org/lkml/20220212201631.12648-1-s.shtylyov@omp.ru/

I don't see those two upstream yet, on a quick glance. Perhaps in Greg's tree?

Greg, what's the latest with that platform_get_*_optional() fun?

Also, the second of those two patches above has:

+ * Return: non-zero IRQ number on success, 0 if IRQ wasn't found, negative error
+ * number on failure.
  */
 int platform_get_irq_byname_optional(struct platform_device *dev,

and your patch does:

+		irq = platform_get_irq_byname_optional(pdev, dmc520_irq_configs[idx].name);
 		irqs[idx] = irq;

so on failure, it would still write the negative error value in
irqs[idx].

How can that be right?

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette