lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list] 
Message-ID: <SJ0PR03MB6681CB77F45CE973DF87B01E8AF39@SJ0PR03MB6681.namprd03.prod.outlook.com>
Date:   Mon, 18 Apr 2022 22:32:29 +0000
From:   "Lee, RyanS" <RyanS.Lee@...log.com>
To:     Rob Herring <robh@...nel.org>, Ryan Lee <ryan.lee.analog@...il.com>
CC:     "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
        "pbrobinson@...il.com" <pbrobinson@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "ckeepax@...nsource.cirrus.com" <ckeepax@...nsource.cirrus.com>,
        "lukas.bulwahn@...il.com" <lukas.bulwahn@...il.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "pierre-louis.bossart@...ux.intel.com" 
        <pierre-louis.bossart@...ux.intel.com>,
        "srinivas.kandagatla@...aro.org" <srinivas.kandagatla@...aro.org>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "tanureal@...nsource.cirrus.com" <tanureal@...nsource.cirrus.com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "tiwai@...e.com" <tiwai@...e.com>,
        "cy_huang@...htek.com" <cy_huang@...htek.com>,
        "stephan@...hold.net" <stephan@...hold.net>,
        "arnd@...db.de" <arnd@...db.de>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "hdegoede@...hat.com" <hdegoede@...hat.com>,
        "perex@...ex.cz" <perex@...ex.cz>,
        "drhodes@...nsource.cirrus.com" <drhodes@...nsource.cirrus.com>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>
Subject: RE: [PATCH 1/2] ASoC: dt-bindings: max98396: add amplifier driver

> -----Original Message-----
> From: Rob Herring <robh@...nel.org>
> Sent: Saturday, April 16, 2022 3:18 PM
> To: Ryan Lee <ryan.lee.analog@...il.com>
> Cc: krzk+dt@...nel.org; pbrobinson@...il.com; linux-
> kernel@...r.kernel.org; ckeepax@...nsource.cirrus.com;
> lukas.bulwahn@...il.com; devicetree@...r.kernel.org; pierre-
> louis.bossart@...ux.intel.com; srinivas.kandagatla@...aro.org; alsa-
> devel@...a-project.org; tanureal@...nsource.cirrus.com;
> broonie@...nel.org; tiwai@...e.com; cy_huang@...htek.com;
> stephan@...hold.net; arnd@...db.de; robh+dt@...nel.org;
> hdegoede@...hat.com; perex@...ex.cz;
> drhodes@...nsource.cirrus.com; Lee, RyanS
> <RyanS.Lee@...log.com>; lgirdwood@...il.com
> Subject: Re: [PATCH 1/2] ASoC: dt-bindings: max98396: add amplifier
> driver
> 
> [External]
> 
> On Fri, 15 Apr 2022 17:40:23 -0700, Ryan Lee wrote:
> > From: Ryan Lee <ryans.lee@...log.com>
> >
> > This patch adds dt-bindings information for Analog Devices
> MAX98396
> > and MAX98397 Smart Amplifier.
> >
> > Signed-off-by: Ryan Lee <ryans.lee@...log.com>
> > ---
> >  .../bindings/sound/adi,max98396.yaml          | 84
> +++++++++++++++++++
> >  1 file changed, 84 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/sound/adi,max98396.yaml
> >
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m
> dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 

I appreciate your feedback. I was able to check the same issues on my side.
I shall fix the problem and submit the updated patch.

> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/sound/adi,max98396.yaml:49:1
> 11: [warning] line too long (121 > 110 characters) (line-length)
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/sound/adi,max98396.ya
> ml: properties:adi,spkfb-slot-no: 'oneOf' conditional failed, one must
> be fixed:
> 	'type' is a required property
> 		hint: A vendor boolean property can use "type:
> boolean"
> 	Additional properties are not allowed ('maximum', 'default',
> 'minimum' were unexpected)
> 		hint: A vendor boolean property can use "type:
> boolean"
> 	/builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/sound/adi,max98396.ya
> ml: properties:adi,spkfb-slot-no: 'oneOf' conditional failed, one must
> be fixed:
> 		'enum' is a required property
> 		'const' is a required property
> 		hint: A vendor string property with exact values has an
> implicit type
> 		from schema $id:
> https://urldefense.com/v3/__http://devicetree.org/meta-
> schemas/vendor-
> props.yaml*__;Iw!!A3Ni8CS0y2Y!6AbqO57BdHk8HsfdSgsIJ96PVLttFGa
> Nyp2EOec4EnuAYY4aQ25BDE2H4waOpyi0_juZ-wiHiNs8$
> 	/builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/sound/adi,max98396.ya
> ml: properties:adi,spkfb-slot-no: 'oneOf' conditional failed, one must
> be fixed:
> 		'$ref' is a required property
> 		'allOf' is a required property
> 		hint: A vendor property needs a $ref to types.yaml
> 		from schema $id:
> https://urldefense.com/v3/__http://devicetree.org/meta-
> schemas/vendor-
> props.yaml*__;Iw!!A3Ni8CS0y2Y!6AbqO57BdHk8HsfdSgsIJ96PVLttFGa
> Nyp2EOec4EnuAYY4aQ25BDE2H4waOpyi0_juZ-wiHiNs8$
> 	hint: Vendor specific properties must have a type and
> description unless they have a defined, common suffix.
> 	from schema $id:
> https://urldefense.com/v3/__http://devicetree.org/meta-
> schemas/vendor-
> props.yaml*__;Iw!!A3Ni8CS0y2Y!6AbqO57BdHk8HsfdSgsIJ96PVLttFGa
> Nyp2EOec4EnuAYY4aQ25BDE2H4waOpyi0_juZ-wiHiNs8$
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/sound/adi,max98396.ya
> ml: properties:adi,interleave-mode: 'oneOf' conditional failed, one
> must be fixed:
> 	Additional properties are not allowed ('default' was
> unexpected)
> 		hint: A vendor boolean property can use "type:
> boolean"
> 	/builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/sound/adi,max98396.ya
> ml: properties:adi,interleave-mode: 'oneOf' conditional failed, one
> must be fixed:
> 		'enum' is a required property
> 		'const' is a required property
> 		hint: A vendor string property with exact values has an
> implicit type
> 		from schema $id:
> https://urldefense.com/v3/__http://devicetree.org/meta-
> schemas/vendor-
> props.yaml*__;Iw!!A3Ni8CS0y2Y!6AbqO57BdHk8HsfdSgsIJ96PVLttFGa
> Nyp2EOec4EnuAYY4aQ25BDE2H4waOpyi0_juZ-wiHiNs8$
> 	Additional properties are not allowed ('type', 'default' were
> unexpected)
> 		hint: A vendor string property with exact values has an
> implicit type
> 	/builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/sound/adi,max98396.ya
> ml: properties:adi,interleave-mode: 'oneOf' conditional failed, one
> must be fixed:
> 		'$ref' is a required property
> 		'allOf' is a required property
> 		hint: A vendor property needs a $ref to types.yaml
> 		from schema $id:
> https://urldefense.com/v3/__http://devicetree.org/meta-
> schemas/vendor-
> props.yaml*__;Iw!!A3Ni8CS0y2Y!6AbqO57BdHk8HsfdSgsIJ96PVLttFGa
> Nyp2EOec4EnuAYY4aQ25BDE2H4waOpyi0_juZ-wiHiNs8$
> 	hint: Vendor specific properties must have a type and
> description unless they have a defined, common suffix.
> 	from schema $id:
> https://urldefense.com/v3/__http://devicetree.org/meta-
> schemas/vendor-
> props.yaml*__;Iw!!A3Ni8CS0y2Y!6AbqO57BdHk8HsfdSgsIJ96PVLttFGa
> Nyp2EOec4EnuAYY4aQ25BDE2H4waOpyi0_juZ-wiHiNs8$
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/sound/adi,max98396.ya
> ml: properties:adi,vmon-slot-no: 'oneOf' conditional failed, one must
> be fixed:
> 	'type' is a required property
> 		hint: A vendor boolean property can use "type:
> boolean"
> 	Additional properties are not allowed ('maximum', 'default',
> 'minimum' were unexpected)
> 		hint: A vendor boolean property can use "type:
> boolean"
> 	/builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/sound/adi,max98396.ya
> ml: properties:adi,vmon-slot-no: 'oneOf' conditional failed, one must
> be fixed:
> 		'enum' is a required property
> 		'const' is a required property
> 		hint: A vendor string property with exact values has an
> implicit type
> 		from schema $id:
> https://urldefense.com/v3/__http://devicetree.org/meta-
> schemas/vendor-
> props.yaml*__;Iw!!A3Ni8CS0y2Y!6AbqO57BdHk8HsfdSgsIJ96PVLttFGa
> Nyp2EOec4EnuAYY4aQ25BDE2H4waOpyi0_juZ-wiHiNs8$
> 	/builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/sound/adi,max98396.ya
> ml: properties:adi,vmon-slot-no: 'oneOf' conditional failed, one must
> be fixed:
> 		'$ref' is a required property
> 		'allOf' is a required property
> 		hint: A vendor property needs a $ref to types.yaml
> 		from schema $id:
> https://urldefense.com/v3/__http://devicetree.org/meta-
> schemas/vendor-
> props.yaml*__;Iw!!A3Ni8CS0y2Y!6AbqO57BdHk8HsfdSgsIJ96PVLttFGa
> Nyp2EOec4EnuAYY4aQ25BDE2H4waOpyi0_juZ-wiHiNs8$
> 	hint: Vendor specific properties must have a type and
> description unless they have a defined, common suffix.
> 	from schema $id:
> https://urldefense.com/v3/__http://devicetree.org/meta-
> schemas/vendor-
> props.yaml*__;Iw!!A3Ni8CS0y2Y!6AbqO57BdHk8HsfdSgsIJ96PVLttFGa
> Nyp2EOec4EnuAYY4aQ25BDE2H4waOpyi0_juZ-wiHiNs8$
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/sound/adi,max98396.ya
> ml: properties:adi,imon-slot-no: 'oneOf' conditional failed, one must
> be fixed:
> 	'type' is a required property
> 		hint: A vendor boolean property can use "type:
> boolean"
> 	Additional properties are not allowed ('maximum', 'default',
> 'minimum' were unexpected)
> 		hint: A vendor boolean property can use "type:
> boolean"
> 	/builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/sound/adi,max98396.ya
> ml: properties:adi,imon-slot-no: 'oneOf' conditional failed, one must
> be fixed:
> 		'enum' is a required property
> 		'const' is a required property
> 		hint: A vendor string property with exact values has an
> implicit type
> 		from schema $id:
> https://urldefense.com/v3/__http://devicetree.org/meta-
> schemas/vendor-
> props.yaml*__;Iw!!A3Ni8CS0y2Y!6AbqO57BdHk8HsfdSgsIJ96PVLttFGa
> Nyp2EOec4EnuAYY4aQ25BDE2H4waOpyi0_juZ-wiHiNs8$
> 	/builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/sound/adi,max98396.ya
> ml: properties:adi,imon-slot-no: 'oneOf' conditional failed, one must
> be fixed:
> 		'$ref' is a required property
> 		'allOf' is a required property
> 		hint: A vendor property needs a $ref to types.yaml
> 		from schema $id:
> https://urldefense.com/v3/__http://devicetree.org/meta-
> schemas/vendor-
> props.yaml*__;Iw!!A3Ni8CS0y2Y!6AbqO57BdHk8HsfdSgsIJ96PVLttFGa
> Nyp2EOec4EnuAYY4aQ25BDE2H4waOpyi0_juZ-wiHiNs8$
> 	hint: Vendor specific properties must have a type and
> description unless they have a defined, common suffix.
> 	from schema $id:
> https://urldefense.com/v3/__http://devicetree.org/meta-
> schemas/vendor-
> props.yaml*__;Iw!!A3Ni8CS0y2Y!6AbqO57BdHk8HsfdSgsIJ96PVLttFGa
> Nyp2EOec4EnuAYY4aQ25BDE2H4waOpyi0_juZ-wiHiNs8$
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/sound/adi,max98396.ya
> ml: ignoring, error in schema: properties: adi,spkfb-slot-no
> Documentation/devicetree/bindings/sound/adi,max98396.example.dt
> b:0:0: /example-0/i2c/amplifier@39: failed to match any schema with
> compatible: ['adi,max98396']
> Documentation/devicetree/bindings/sound/adi,max98396.example.dt
> b:0:0: /example-0/i2c/amplifier@3c: failed to match any schema with
> compatible: ['adi,max98397']
> 
> doc reference errors (make refcheckdocs):
> 
> See
> https://urldefense.com/v3/__https://patchwork.ozlabs.org/patch/__;!
> !A3Ni8CS0y2Y!6AbqO57BdHk8HsfdSgsIJ96PVLttFGaNyp2EOec4EnuAYY
> 4aQ25BDE2H4waOpyi0_juZ-xmX_4-e$
> 
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ