[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAA8EJpqh1pTfNR2Qd7p69i4VvqPNtbd5gOjO-TYdWTTG1rKrrA@mail.gmail.com>
Date: Tue, 19 Apr 2022 01:34:19 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Bhupesh Sharma <bhupesh.sharma@...aro.org>
Cc: linux-arm-msm@...r.kernel.org, linux-phy@...ts.infradead.org,
bhupesh.linux@...il.com, agross@...nel.org,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
robh+dt@...nel.org, vkoul@...nel.org, bjorn.andersson@...aro.org,
Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v3 2/4] dt-bindings: phy: qcom,qmp: Describe
'vdda-max-microamp' & 'vdda-pll-max-microamp' properties
On Mon, 18 Apr 2022 at 23:55, Bhupesh Sharma <bhupesh.sharma@...aro.org> wrote:
>
> Since a few boards based on QCoM qmp phy use the
> 'vdda-max-microamp' & 'vdda-pll-max-microamp' properties to
> describe the ufs phy nodes, add them to the dt-bindings doc as well.
Ugh. They give a false sense that they are supported. I think in
reality they are not used by the kernel.
So, ideally, this patch should be accompanied with regulator core change.
Or (better) drop them completely.
>
> This fixes the following '$ make dtbs_check' warning(s):
>
> sm8350-microsoft-surface-duo2.dt.yaml: phy@...7000:
> 'vdda-max-microamp', 'vdda-pll-max-microamp' do not match any of
> the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+'
>
> Cc: Bjorn Andersson <bjorn.andersson@...aro.org>
> Cc: Vinod Koul <vkoul@...nel.org>
> Acked-by: Rob Herring <robh@...nel.org>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@...aro.org>
> ---
> Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> index c39ead81ecd7..411c79dbfa15 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> @@ -90,6 +90,14 @@ properties:
> minItems: 1
> maxItems: 3
>
> + vdda-max-microamp:
> + description:
> + Specifies max. load that can be drawn from phy supply.
> +
> + vdda-pll-max-microamp:
> + description:
> + Specifies max. load that can be drawn from pll supply.
> +
> vdda-phy-supply:
> description:
> Phandle to a regulator supply to PHY core block.
> --
> 2.35.1
>
--
With best wishes
Dmitry
Powered by blists - more mailing lists