linux-kernel - Re: [PATCH] gpio: use raw spinlock for gpio chip shadowed data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMA88Tr6NvfEiPYnt0A60GiQKiiT6LT7X83GRku-4PDcG2EtoA@mail.gmail.com>
Date:   Mon, 18 Apr 2022 11:07:21 +0800
From:   Schspa Shi <schspa@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     "brgl@...ev.pl" <brgl@...ev.pl>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "fancer.lancer@...il.com" <fancer.lancer@...il.com>,
        "hoan@...amperecomputing.com" <hoan@...amperecomputing.com>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "opendmb@...il.com" <opendmb@...il.com>
Subject: Re: [PATCH] gpio: use raw spinlock for gpio chip shadowed data

Andy Shevchenko <andy.shevchenko@...il.com> writes:

>
>  Changelog:
>  v1 -> v2:
>          - Reduce the useless stacktrace.
>          - Split to series of patches
>
> Changelog usually goes after cutter ‘--- ‘ line.  Besides that you haven’t compiled your tree just after this patch.
>

Yes, thanks for reminding me, I will fix it by upload another version
of patch if there is no other problems.

>  Link: https://lore.kernel.org/all/20220415165505.30383-1-schspa@gmail.com/
>
>  Signed-off-by: Schspa Shi <schspa@...il.com>
>  ---
>   drivers/gpio/gpio-mmio.c    | 22 +++++++++++-----------
>   include/linux/gpio/driver.h |  2 +-
>
> You can’t do it for one driver only. As I told it will require too much of additional churn to make this to be series.
>

It seems I have misunderstood your "too much of additional churn". Can
you explain it?
The gpio-mmio.c and driver.h here are the basics of other gpio
drivers. In my opinion, these two files
belong to the basic code of gpio, and functions such as bgpio_init are
declared in
include/linux/gpio/driver.h and implemented in
drivers/gpio/gpio-mmio.c. So there is no churn.


--
Schspa Shi
BRs