lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d56ad1bc0ef918cc8395b7c0ec7bdd10baf4c1f6.camel@perches.com>
Date:   Mon, 18 Apr 2022 05:34:02 -0700
From:   Joe Perches <joe@...ches.com>
To:     Nava kishore Manne <navam@...inx.com>,
        "mdf@...nel.org" <mdf@...nel.org>,
        "hao.wu@...el.com" <hao.wu@...el.com>,
        "yilun.xu@...el.com" <yilun.xu@...el.com>,
        "trix@...hat.com" <trix@...hat.com>,
        Michal Simek <michals@...inx.com>,
        "linux-fpga@...r.kernel.org" <linux-fpga@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>, git <git@...inx.com>
Subject: Re: [PATCH v4 2/5] fpga: fix for coding style issues

On Mon, 2022-04-18 at 09:54 +0000, Nava kishore Manne wrote:
> Hi Joe,
> 
> 	Please find my response inline.
> 
> > -----Original Message-----
> > From: Joe Perches <joe@...ches.com>
> > Sent: Saturday, April 16, 2022 10:29 PM

> > On Sat, 2022-04-16 at 19:07 +0530, Nava kishore Manne wrote:
> > > fixes the below checks reported by checkpatch.pl Lines should not end
> > > with a '('
> > > Alignment should match open parenthesis
> > 
> > in fpga-mgr:
> > 	Another possibillty would be to change the function arguments
> > 
> > and
> > 
> > in fpga-region:
> > 	Ideally keep the include declaration and definition styles synced
> 
> These changes are targeted to fix the checks reported by checkpatch.pl without touching the actual functionality.

Hello.

I am the checkpatch maintainer.

The goal of the checkpatch script is simply to mark things that
generally don't conform to the typical kernel coding style not
to mandate that all of the messages it emits is dicta.

checkpatch is a stupid little script.  It has no taste.

Please take what I wrote with a little consideration rather than
follow the advise of a brainless script.


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ