[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <SN6PR02MB45761359B029B065092F8691C2F29@SN6PR02MB4576.namprd02.prod.outlook.com>
Date: Tue, 19 Apr 2022 08:15:57 +0000
From: Nava kishore Manne <navam@...inx.com>
To: Joe Perches <joe@...ches.com>, "mdf@...nel.org" <mdf@...nel.org>,
"hao.wu@...el.com" <hao.wu@...el.com>,
"yilun.xu@...el.com" <yilun.xu@...el.com>,
"trix@...hat.com" <trix@...hat.com>,
Michal Simek <michals@...inx.com>,
"linux-fpga@...r.kernel.org" <linux-fpga@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>, git <git@...inx.com>
Subject: RE: [PATCH v4 2/5] fpga: fix for coding style issues
Hi Joe,
Please find my response inline.
> -----Original Message-----
> From: Joe Perches <joe@...ches.com>
> Sent: Monday, April 18, 2022 6:04 PM
> To: Nava kishore Manne <navam@...inx.com>; mdf@...nel.org;
> hao.wu@...el.com; yilun.xu@...el.com; trix@...hat.com; Michal Simek
> <michals@...inx.com>; linux-fpga@...r.kernel.org; linux-
> kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; git
> <git@...inx.com>
> Subject: Re: [PATCH v4 2/5] fpga: fix for coding style issues
>
> On Mon, 2022-04-18 at 09:54 +0000, Nava kishore Manne wrote:
> > Hi Joe,
> >
> > Please find my response inline.
> >
> > > -----Original Message-----
> > > From: Joe Perches <joe@...ches.com>
> > > Sent: Saturday, April 16, 2022 10:29 PM
>
> > > On Sat, 2022-04-16 at 19:07 +0530, Nava kishore Manne wrote:
> > > > fixes the below checks reported by checkpatch.pl Lines should not
> > > > end with a '('
> > > > Alignment should match open parenthesis
> > >
> > > in fpga-mgr:
> > > Another possibillty would be to change the function arguments
> > >
This API is there for a long back. Not sure changing the function arguments is fine or Not.
@yilun: Is it ok to change the function arguments?
> > > and
> > >
> > > in fpga-region:
> > > Ideally keep the include declaration and definition styles synced
> >
Will fix it in next version.
Regards,
Navakishore.
Powered by blists - more mailing lists