linux-kernel - Re: [PATCH v4 2/5] fpga: fix for coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220419094521.GA322948@yilunxu-OptiPlex-7050>
Date:   Tue, 19 Apr 2022 17:45:21 +0800
From:   Xu Yilun <yilun.xu@...el.com>
To:     Nava kishore Manne <navam@...inx.com>
Cc:     Joe Perches <joe@...ches.com>, "mdf@...nel.org" <mdf@...nel.org>,
        "hao.wu@...el.com" <hao.wu@...el.com>,
        "trix@...hat.com" <trix@...hat.com>,
        Michal Simek <michals@...inx.com>,
        "linux-fpga@...r.kernel.org" <linux-fpga@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>, git <git@...inx.com>
Subject: Re: [PATCH v4 2/5] fpga: fix for coding style issues

On Tue, Apr 19, 2022 at 08:15:57AM +0000, Nava kishore Manne wrote:
> Hi Joe,
> 
> 	Please find my response inline.
> 
> > -----Original Message-----
> > From: Joe Perches <joe@...ches.com>
> > Sent: Monday, April 18, 2022 6:04 PM
> > To: Nava kishore Manne <navam@...inx.com>; mdf@...nel.org;
> > hao.wu@...el.com; yilun.xu@...el.com; trix@...hat.com; Michal Simek
> > <michals@...inx.com>; linux-fpga@...r.kernel.org; linux-
> > kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; git
> > <git@...inx.com>
> > Subject: Re: [PATCH v4 2/5] fpga: fix for coding style issues
> > 
> > On Mon, 2022-04-18 at 09:54 +0000, Nava kishore Manne wrote:
> > > Hi Joe,
> > >
> > > 	Please find my response inline.
> > >
> > > > -----Original Message-----
> > > > From: Joe Perches <joe@...ches.com>
> > > > Sent: Saturday, April 16, 2022 10:29 PM
> > 
> > > > On Sat, 2022-04-16 at 19:07 +0530, Nava kishore Manne wrote:
> > > > > fixes the below checks reported by checkpatch.pl Lines should not
> > > > > end with a '('
> > > > > Alignment should match open parenthesis
> > > >
> > > > in fpga-mgr:
> > > > 	Another possibillty would be to change the function arguments
> > > >
> 
> This API is there for a long back. Not sure changing the function arguments is fine or Not.
> @yilun: Is it ok to change the function arguments?

Joe's example code below doesn't actually change any function definition.
It just tries to store the value of 'min(mgr->mops->initial_header_size, count)'
in 'count', thus to reduce the length of the 'fpga_mgr_write_init(...)'
expression.

So I think it is OK.

Thanks,
Yilun

> 
> > > > and
> > > >
> > > > in fpga-region:
> > > > 	Ideally keep the include declaration and definition styles synced
> > >
> 
> Will fix it in next version.
> 
> Regards,
> Navakishore.