linux-kernel - Re: [PATCH v3] perf report: Set PERF_SAMPLE_DATA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220419012114.GF166256@leoy-ThinkPad-X240s>
Date:   Tue, 19 Apr 2022 09:21:14 +0800
From:   Leo Yan <leo.yan@...aro.org>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Ravi Bangoria <ravi.bangoria@...ux.ibm.com>,
        James Clark <james.clark@....com>,
        German Gomez <german.gomez@....com>,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] perf report: Set PERF_SAMPLE_DATA_SRC bit for Arm SPE
 event

On Mon, Apr 18, 2022 at 06:56:26PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Apr 14, 2022 at 08:32:01PM +0800, Leo Yan escreveu:
> > Since commit bb30acae4c4d ("perf report: Bail out --mem-mode if mem info
> > is not available") "perf mem report" and "perf report --mem-mode"
> > don't report result if the PERF_SAMPLE_DATA_SRC bit is missed in sample
> > type.
> > 
> > The commit ffab48705205 ("perf: arm-spe: Fix perf report --mem-mode")
> > partially fixes the issue.  It adds PERF_SAMPLE_DATA_SRC bit for Arm SPE
> > event, this allows the perf data file generated by kernel v5.18-rc1 or
> > later version can be reported properly.
> > 
> > On the other hand, perf tool still fails to be backward compatibility
> > for a data file recorded by an older version's perf which contains Arm
> > SPE trace data.  This patch is a workaround in reporting phase, when
> > detects ARM SPE PMU event and without PERF_SAMPLE_DATA_SRC bit, it will
> > force to set the bit in the sample type and give a warning info.
> 
> Thanks, applied.

Thank you, Arnaldo!

Leo