linux-kernel - Re: [PATCH] drm/bridge: anx7625: Fill in empty ELD when no connector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220419022932.GA629745@anxtwsw-Precision-3640-Tower>
Date:   Tue, 19 Apr 2022 10:29:32 +0800
From:   Xin Ji <xji@...logixsemi.com>
To:     Hsin-Yi Wang <hsinyi@...omium.org>
Cc:     Robert Foss <robert.foss@...aro.org>,
        Andrzej Hajda <andrzej.hajda@...el.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Jonas Karlman <jonas@...boo.se>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Maxime Ripard <maxime@...no.tech>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/bridge: anx7625: Fill in empty ELD when no connector

On Thu, Apr 14, 2022 at 05:00:04PM +0800, Hsin-Yi Wang wrote:
> Speaker may share I2S with DP and .get_eld callback will be called when
> speaker is playing. When HDMI wans't connected, the connector will be
> null. Instead of return an error, fill in empty ELD.
> 
> Signed-off-by: Hsin-Yi Wang <hsinyi@...omium.org>
> ---
>  drivers/gpu/drm/bridge/analogix/anx7625.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index 6516f9570b86..f2bc30c98c77 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -1932,14 +1932,14 @@ static int anx7625_audio_get_eld(struct device *dev, void *data,
>  	struct anx7625_data *ctx = dev_get_drvdata(dev);
>  
>  	if (!ctx->connector) {
> -		dev_err(dev, "connector not initial\n");
> -		return -EINVAL;
> +		/* Pass en empty ELD if connector not available */
> +		memset(buf, 0, len);
> +	} else {
> +		dev_dbg(dev, "audio copy eld\n");
> +		memcpy(buf, ctx->connector->eld,
> +		       min(sizeof(ctx->connector->eld), len));
>  	}
>  
> -	dev_dbg(dev, "audio copy eld\n");
> -	memcpy(buf, ctx->connector->eld,
> -	       min(sizeof(ctx->connector->eld), len));
> -
>  	return 0;
Hi Hsin-Yi, it's OK for me.
Reviewed-by: Xin Ji <xji@...logixsemi.com>

Thanks,
Xin
>  }
>  
> -- 
> 2.35.1.1178.g4f1659d476-goog