linux-kernel - Re: [PATCH 2/2] userfaultfd: selftests: modify selftest to use /dev/userfaultfd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20220418203223.02d00391505b662e71e8c1db@linux-foundation.org>
Date:   Mon, 18 Apr 2022 20:32:23 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Axel Rasmussen <axelrasmussen@...gle.com>
Cc:     Alexander Viro <viro@...iv.linux.org.uk>,
        "Dmitry V . Levin" <ldv@...linux.org>,
        Gleb Fotengauer-Malinovskiy <glebfm@...linux.org>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        Nadav Amit <namit@...are.com>, Peter Xu <peterx@...hat.com>,
        Shuah Khan <shuah@...nel.org>, linux-fsdevel@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        Linux MM <linux-mm@...ck.org>,
        Linuxkselftest <linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH 2/2] userfaultfd: selftests: modify selftest to use
 /dev/userfaultfd

On Mon, 18 Apr 2022 15:16:02 -0700 Axel Rasmussen <axelrasmussen@...gle.com> wrote:

> Thanks for looking Andrew. And, fair criticism.
> 
> In keeping with the status quo, I'm thinking of just adding a new
> command-line argument which toggles between the two modes.

But I think you could tweak the test pretty simply to run itself twice.
Once with the syscall then once with the /dev interface.

I suppose that adding the commandline argument is equivalent, as long
as the upper level script/makefile invokes the test program twice.

> But, if I'm honest, it's starting to feel like the test has way too
> many arguments... I'm tempted to refactor the test to use the
> kselftest framework [1], get rid of all these command line arguments,
> and just always test everything. But, this seems like a big and
> perhaps controversial refactor, so I may take it up after this
> series...

Yes, that's a separable activity.