| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 Apr 2022 13:45:38 +0800
From: kernel test robot <lkp@...el.com>
To: Ingo Molnar <mingo@...nel.org>
Cc: llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
linux-kernel@...r.kernel.org
Subject: [mingo-tip:sched/headers 1707/2356] drivers/spi/spi-intel.c:549:27:
error: use of undeclared identifier 'SZ_4K'
tree: git://git.kernel.org/pub/scm/linux/kernel/git/mingo/tip.git sched/headers
head: af93551cf39027d176f30b9beafc60a4c130998a
commit: 26730fd8712d97926bd7b6517dba4e77a24314ea [1707/2356] headers/deps: lib/scatterlist: Optimize <linux/scatterlist_types.h> dependencies, remove <linux/mm.h>
config: x86_64-randconfig-a014-20220418 (https://download.01.org/0day-ci/archive/20220419/202204191301.Nv9tUAUw-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 429cbac0390654f90bba18a41799464adf31a5ec)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/mingo/tip.git/commit/?id=26730fd8712d97926bd7b6517dba4e77a24314ea
git remote add mingo-tip git://git.kernel.org/pub/scm/linux/kernel/git/mingo/tip.git
git fetch --no-tags mingo-tip sched/headers
git checkout 26730fd8712d97926bd7b6517dba4e77a24314ea
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
In file included from drivers/spi/spi-intel.c:13:
In file included from include/linux/mtd/spi-nor.h:10:
include/linux/mtd/cfi.h:62:2: warning: No CONFIG_MTD_CFI_Ix selected. No NOR chip support can work. [-W#warnings]
#warning No CONFIG_MTD_CFI_Ix selected. No NOR chip support can work.
^
>> drivers/spi/spi-intel.c:549:27: error: use of undeclared identifier 'SZ_4K'
round_up(addr + 1, SZ_4K)) - addr;
^
>> drivers/spi/spi-intel.c:549:27: error: use of undeclared identifier 'SZ_4K'
drivers/spi/spi-intel.c:606:27: error: use of undeclared identifier 'SZ_4K'
round_up(addr + 1, SZ_4K)) - addr;
^
drivers/spi/spi-intel.c:606:27: error: use of undeclared identifier 'SZ_4K'
1 warning and 4 errors generated.
vim +/SZ_4K +549 drivers/spi/spi-intel.c
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 526
e23e5a05d1fd94 drivers/spi/spi-intel.c Mika Westerberg 2022-02-09 527 static int intel_spi_read(struct intel_spi *ispi,
e23e5a05d1fd94 drivers/spi/spi-intel.c Mika Westerberg 2022-02-09 528 const struct intel_spi_mem_op *iop,
e23e5a05d1fd94 drivers/spi/spi-intel.c Mika Westerberg 2022-02-09 529 const struct spi_mem_op *op)
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 530 {
e23e5a05d1fd94 drivers/spi/spi-intel.c Mika Westerberg 2022-02-09 531 void *read_buf = op->data.buf.in;
e23e5a05d1fd94 drivers/spi/spi-intel.c Mika Westerberg 2022-02-09 532 size_t block_size, nbytes = op->data.nbytes;
e23e5a05d1fd94 drivers/spi/spi-intel.c Mika Westerberg 2022-02-09 533 u32 addr = op->addr.val;
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 534 u32 val, status;
e23e5a05d1fd94 drivers/spi/spi-intel.c Mika Westerberg 2022-02-09 535 int ret;
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 536
c7d6a82d90e193 drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2018-02-05 537 /*
c7d6a82d90e193 drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2018-02-05 538 * Atomic sequence is not expected with HW sequencer reads. Make
c7d6a82d90e193 drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2018-02-05 539 * sure it is cleared regardless.
c7d6a82d90e193 drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2018-02-05 540 */
c7d6a82d90e193 drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2018-02-05 541 if (WARN_ON_ONCE(ispi->atomic_preopcode))
c7d6a82d90e193 drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2018-02-05 542 ispi->atomic_preopcode = 0;
c7d6a82d90e193 drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2018-02-05 543
e23e5a05d1fd94 drivers/spi/spi-intel.c Mika Westerberg 2022-02-09 544 while (nbytes > 0) {
e23e5a05d1fd94 drivers/spi/spi-intel.c Mika Westerberg 2022-02-09 545 block_size = min_t(size_t, nbytes, INTEL_SPI_FIFO_SZ);
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 546
2b75ebeea6f493 drivers/mtd/spi-nor/intel-spi.c Alexander Sverdlin 2019-03-19 547 /* Read cannot cross 4K boundary */
e23e5a05d1fd94 drivers/spi/spi-intel.c Mika Westerberg 2022-02-09 548 block_size = min_t(loff_t, addr + block_size,
e23e5a05d1fd94 drivers/spi/spi-intel.c Mika Westerberg 2022-02-09 @549 round_up(addr + 1, SZ_4K)) - addr;
2b75ebeea6f493 drivers/mtd/spi-nor/intel-spi.c Alexander Sverdlin 2019-03-19 550
e23e5a05d1fd94 drivers/spi/spi-intel.c Mika Westerberg 2022-02-09 551 writel(addr, ispi->base + FADDR);
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 552
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 553 val = readl(ispi->base + HSFSTS_CTL);
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 554 val &= ~(HSFSTS_CTL_FDBC_MASK | HSFSTS_CTL_FCYCLE_MASK);
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 555 val |= HSFSTS_CTL_AEL | HSFSTS_CTL_FCERR | HSFSTS_CTL_FDONE;
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 556 val |= (block_size - 1) << HSFSTS_CTL_FDBC_SHIFT;
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 557 val |= HSFSTS_CTL_FCYCLE_READ;
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 558 val |= HSFSTS_CTL_FGO;
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 559 writel(val, ispi->base + HSFSTS_CTL);
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 560
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 561 ret = intel_spi_wait_hw_busy(ispi);
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 562 if (ret)
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 563 return ret;
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 564
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 565 status = readl(ispi->base + HSFSTS_CTL);
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 566 if (status & HSFSTS_CTL_FCERR)
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 567 ret = -EIO;
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 568 else if (status & HSFSTS_CTL_AEL)
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 569 ret = -EACCES;
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 570
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 571 if (ret < 0) {
e23e5a05d1fd94 drivers/spi/spi-intel.c Mika Westerberg 2022-02-09 572 dev_err(ispi->dev, "read error: %x: %#x\n", addr, status);
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 573 return ret;
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 574 }
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 575
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 576 ret = intel_spi_read_block(ispi, read_buf, block_size);
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 577 if (ret)
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 578 return ret;
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 579
e23e5a05d1fd94 drivers/spi/spi-intel.c Mika Westerberg 2022-02-09 580 nbytes -= block_size;
e23e5a05d1fd94 drivers/spi/spi-intel.c Mika Westerberg 2022-02-09 581 addr += block_size;
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 582 read_buf += block_size;
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 583 }
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 584
e23e5a05d1fd94 drivers/spi/spi-intel.c Mika Westerberg 2022-02-09 585 return 0;
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 586 }
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 587
:::::: The code at line 549 was first introduced by commit
:::::: e23e5a05d1fd9479586c40ffbcc056b3e34ef816 mtd: spi-nor: intel-spi: Convert to SPI MEM
:::::: TO: Mika Westerberg <mika.westerberg@...ux.intel.com>
:::::: CC: Mark Brown <broonie@...nel.org>
--
0-DAY CI Kernel Test Service
https://01.org/lkp
Powered by blists - more mailing lists