linux-kernel - Re: linux-next: Fixes tag needs some work in the crypto tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yl6Rwe1okkWqC6ou@silpixa00400314>
Date:   Tue, 19 Apr 2022 11:41:05 +0100
From:   Giovanni Cabiddu <giovanni.cabiddu@...el.com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Herbert Xu <herbert@...dor.apana.org.au>
Cc:     Linux Crypto List <linux-crypto@...r.kernel.org>,
        Marco Chiappero <marco.chiappero@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the crypto tree

Thanks Stephen.

On Tue, Apr 19, 2022 at 07:17:22AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   c690c7f6312c ("crypto: qat - rework the VF2PF interrupt handling logic")
> 
> Fixes tag
> 
>   Fixes: 993161d ("crypto: qat - fix handling of VF to PF interrupts")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     This can be fixed for the future by setting core.abbrev to 12 (or
>     more) or (for git v2.11 or later) just making sure it is not set
>     (or set to "auto").
Apologies, I missed this during the review of the patch.

@Herbert, should I resend the patch with the correct Fixes tag or can
you amend the commit in your tree.

This should be the correct tag:
    Fixes: 993161d36ab5 ("crypto: qat - fix handling of VF to PF interrupts")

Regards,

-- 
Giovanni