linux-kernel - Re: [PATCH v3 2/5] dt-bindings: clock: Document MA35D1 clock controller bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c59686fe-a9dd-9835-2ccb-e574ea01d7a2@nuvoton.com>
Date:   Tue, 19 Apr 2022 18:49:01 +0800
From:   Jacky Huang <ychuang3@...oton.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-clk@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <ychuang570808@...il.com>
CC:     <robh+dt@...nel.org>, <sboyd@...nel.org>, <krzk+dt@...nel.org>,
        <arnd@...db.de>, <olof@...om.net>, <will@...nel.org>,
        <soc@...nel.org>, <cfli0@...oton.com>
Subject: Re: [PATCH v3 2/5] dt-bindings: clock: Document MA35D1 clock
 controller bindings



On 2022/4/19 下午 06:39, Krzysztof Kozlowski wrote:
> On 19/04/2022 12:12, Jacky Huang wrote:
>>>> +
>>>> +  assigned-clock-rates:
>>>> +    minItems: 5
>>>> +    maxItems: 5
>>>> +
>>>> +  nuvoton,clk-pll-mode:
>>>> +    A list of PLL operation mode corresponding to DDRPLL, APLL, EPLL,
>>>> +    and VPLL in sequential.
>>> This does not look like a binding which was tested. Read
>>> "writing-schema" and test your bindings.
>> "nuvoton,clk-pll-mode" is a nonstandard property used to describe the
>> operation mode of
>> corresponding PLLs.
>>
>> (According to Device tree Specification section "2.2.4 Properties"
>> Nonstandard property names should specify a unique string prefix, such
>> as a stock ticker symbol, identifying the name of
>> the company or organization that defined the property. Examples:
> I am not saying about property name. I replied under some description
> below which fails to build.
>
> Instead please test your bindings.
>
> Best regards,
> Krzysztof

OK, I got it. I found the error by dt_binding_check.
I will fix them in the next version.

Thank you very much.

Jacky Huang