linux-kernel - RE: [PATCH v1 1/3] dt-bindings: PCI: xilinx-cpm: Remove version number in compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 Apr 2022 12:22:50 +0000
From:   Bharat Kumar Gogada <bharatku@...inx.com>
To:     Bjorn Helgaas <helgaas@...nel.org>,
        Michal Simek <michals@...inx.com>
CC:     "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "lorenzo.pieralisi@....com" <lorenzo.pieralisi@....com>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "robh@...nel.org" <robh@...nel.org>
Subject: RE: [PATCH v1 1/3] dt-bindings: PCI: xilinx-cpm: Remove version
 number in compatible string

> On Thu, Apr 14, 2022 at 02:46:25PM +0200, Michal Simek wrote:
> > On 4/14/22 11:22, Bharat Kumar Gogada wrote:
> > > Removing unnecessary version number in compatible string.
> >
> > I am missing reason for this in commit message.
> 
> Agreed.  The commit log for the pcie-xilinx-cpm.c change also needs to
> explain why removing the version is useful and safe.

HI Bjorn, Michal, 

The CPM block is hard block, Rob pointed out that versioning has no value here.
Will resend patch with this detail.

Regards,
Bharat

> 
> > > Signed-off-by: Bharat Kumar Gogada <bharat.kumar.gogada@...inx.com>
> > > ---
> > >   Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml | 4 ++--
> > >   1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml
> > > b/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml
> > > index 32f4641085bc..4ebcc838a1f6 100644
> > > --- a/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml
> > > +++ b/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml
> > > @@ -14,7 +14,7 @@ allOf:
> > >   properties:
> > >     compatible:
> > > -    const: xlnx,versal-cpm-host-1.00
> > > +    const: xlnx,versal-cpm-host
> >
> > And this is likely breaking compatibility for existing DTs.
> >
> > M
> >
> > >     reg:
> > >       items:
> > > @@ -70,7 +70,7 @@ examples:
> > >                  #address-cells = <2>;
> > >                  #size-cells = <2>;
> > >                  cpm_pcie: pcie@...10000 {
> > > -                       compatible = "xlnx,versal-cpm-host-1.00";
> > > +                       compatible = "xlnx,versal-cpm-host";
> > >                          device_type = "pci";
> > >                          #address-cells = <3>;
> > >                          #interrupt-cells = <1>;