linux-kernel - Re: [PATCH v1 1/3] dt-bindings: PCI: xilinx-cpm: Remove version number in compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqJynvpmdF2cBFDQ3og4zgrx9UFtj4NkGUV20f61yc+YtA@mail.gmail.com>
Date:   Tue, 19 Apr 2022 09:12:52 -0500
From:   Rob Herring <robh@...nel.org>
To:     Bharat Kumar Gogada <bharatku@...inx.com>
Cc:     Bjorn Helgaas <helgaas@...nel.org>,
        Michal Simek <michals@...inx.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "lorenzo.pieralisi@....com" <lorenzo.pieralisi@....com>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>
Subject: Re: [PATCH v1 1/3] dt-bindings: PCI: xilinx-cpm: Remove version
 number in compatible string

On Tue, Apr 19, 2022 at 7:22 AM Bharat Kumar Gogada <bharatku@...inx.com> wrote:
>
> > On Thu, Apr 14, 2022 at 02:46:25PM +0200, Michal Simek wrote:
> > > On 4/14/22 11:22, Bharat Kumar Gogada wrote:
> > > > Removing unnecessary version number in compatible string.
> > >
> > > I am missing reason for this in commit message.
> >
> > Agreed.  The commit log for the pcie-xilinx-cpm.c change also needs to
> > explain why removing the version is useful and safe.
>
> HI Bjorn, Michal,
>
> The CPM block is hard block, Rob pointed out that versioning has no value here.
> Will resend patch with this detail.

I did not say to remove the existing version breaking compatibility.
Just don't continue to add new version numbers.

Rob