linux-kernel - Re: [PATCH] mm/uffd: Move USERFAULTFD configs into mm/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 20 Apr 2022 09:46:29 -0700
From:   Axel Rasmussen <axelrasmussen@...gle.com>
To:     Johannes Weiner <hannes@...xchg.org>
Cc:     Peter Xu <peterx@...hat.com>, LKML <linux-kernel@...r.kernel.org>,
        Linux MM <linux-mm@...ck.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Andrea Arcangeli <aarcange@...hat.com>,
        Alistair Popple <apopple@...dia.com>,
        Mike Rapoport <rppt@...ux.vnet.ibm.com>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        Nadav Amit <nadav.amit@...il.com>
Subject: Re: [PATCH] mm/uffd: Move USERFAULTFD configs into mm/

Reviewed-by: Axel Rasmussen <axelrasmussen@...gle.com>

On Wed, Apr 20, 2022 at 8:31 AM Johannes Weiner <hannes@...xchg.org> wrote:
>
> On Wed, Apr 20, 2022 at 10:48:23AM -0400, Peter Xu wrote:
> > We used to have USERFAULTFD configs stored in init/.  It makes sense as a
> > start because that's the default place for storing syscall related configs.
> >
> > However userfaultfd evolved a bit in the past few years and some more
> > config options were added.  They're no longer related to syscalls and start
> > to be not suitable to be kept in the init/ directory anymore, because
> > they're pure mm concepts.
> >
> > But it's not ideal either to keep the userfaultfd configs separate from
> > each other.  Hence this patch moves the userfaultfd configs under init/ to
> > be under mm/ so that we'll start to group all userfaultfd configs
> > together.
> >
> > We do have quite a few examples of syscall related configs that are not put
> > under init/Kconfig: FTRACE_SYSCALLS, SWAP, FILE_LOCKING, MEMFD_CREATE..
> > They all reside in the dir where they're more suitable for the concept. So
> > it seems there's no restriction to keep the role of having syscall related
> > CONFIG_* under init/ only.
> >
> > Suggested-by: Johannes Weiner <hannes@...xchg.org>
> > Signed-off-by: Peter Xu <peterx@...hat.com>
>
> Acked-by: Johannes Weiner <hannes@...xchg.org>