[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Yl9y668H/N+bcrP4@builder.lan>
Date: Tue, 19 Apr 2022 21:41:47 -0500
From: Bjorn Andersson <bjorn.andersson@...aro.org>
To: Bhupesh Sharma <bhupesh.sharma@...aro.org>,
konrad.dybcio@...ainline.org
Cc: linux-arm-msm@...r.kernel.org, linux-phy@...ts.infradead.org,
bhupesh.linux@...il.com, linux-kernel@...r.kernel.org,
vkoul@...nel.org, Marijn Suijten <marijn.suijten@...ainline.org>
Subject: Re: [PATCH v2 1/1] arm64: dts: qcom: sm8350-sagami: usb qmp phy node
- add 'vdda-pll-supply' & 'vdda-phy-supply'
On Tue 19 Apr 15:58 CDT 2022, Bhupesh Sharma wrote:
How about making the subject:
"arm64: dts: qcom: sm8350-sagami: add supplies to USB phy node"
It still says the same thing, but in much less characters.
> As suggested by Bjorn during review of [1], the 'vdda-pll-supply' &
> 'vdda-phy-supply' supplies denote the power for the bus and the
> clock of the usb qmp phy and are used by the qcom qmp phy driver.
>
> So, its safe to assume that the two regulators are the same as on
> the MTP. So let's wire them up in the same way as the MTP.
>
I'm not sure it's "safe to assume", so I would like to get Konrad's
input before merging this.
> In absence of the same 'make dtbs_check' leads to following warnings:
>
> arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami-pdx215.dt.yaml:
> phy-wrapper@...9000: 'vdda-phy-supply' is a required property
>
> arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami-pdx215.dt.yaml:
> phy-wrapper@...9000: 'vdda-pll-supply' is a required property
>
This is good!
Thanks for the patch Bhupesh,
Bjorn
> [1]. https://lore.kernel.org/lkml/20220228123019.382037-9-bhupesh.sharma@linaro.org/
>
> Cc: Bjorn Andersson <bjorn.andersson@...aro.org>
> Cc: konrad.dybcio@...ainline.org
> Cc: Vinod Koul <vkoul@...nel.org>
> Cc: Marijn Suijten <marijn.suijten@...ainline.org>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@...aro.org>
> ---
> Changes since v1:
> -----------------
> - v1 can be found here: https://www.spinics.net/lists/linux-arm-msm/msg108467.html
> - Fixed the commit message to read usb qmp phy instead of ufs phy (which
> was introduced erroraneously in the commit log).
>
> .../dts/qcom/sm8350-sony-xperia-sagami.dtsi | 25 +++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
> index 90b13cbe2fa6..238ac9380ca2 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
> @@ -3,6 +3,7 @@
> * Copyright (c) 2021, Konrad Dybcio <konrad.dybcio@...ainline.org>
> */
>
> +#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> #include "sm8350.dtsi"
> #include "pm8350.dtsi"
> #include "pm8350b.dtsi"
> @@ -75,6 +76,27 @@ ramoops@...00000 {
> };
> };
>
> +&apps_rsc {
> + pm8350-rpmh-regulators {
> + compatible = "qcom,pm8350-rpmh-regulators";
> + qcom,pmic-id = "b";
> +
> + vreg_l1b_0p88: ldo1 {
> + regulator-name = "vreg_l1b_0p88";
> + regulator-min-microvolt = <912000>;
> + regulator-max-microvolt = <920000>;
> + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> + };
> +
> + vreg_l6b_1p2: ldo6 {
> + regulator-name = "vreg_l6b_1p2";
> + regulator-min-microvolt = <1200000>;
> + regulator-max-microvolt = <1208000>;
> + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> + };
> + };
> +};
> +
> &adsp {
> status = "okay";
> firmware-name = "qcom/adsp.mbn";
> @@ -256,4 +278,7 @@ &usb_1_hsphy {
>
> &usb_1_qmpphy {
> status = "okay";
> +
> + vdda-phy-supply = <&vreg_l6b_1p2>;
> + vdda-pll-supply = <&vreg_l1b_0p88>;
> };
> --
> 2.35.1
>
Powered by blists - more mailing lists