linux-kernel - Re: [patch V5 3/3] smp: Make softirq handling RT safe in flush_smp_call_function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YmAtQZHSbcqbwGj4@linutronix.de>
Date:   Wed, 20 Apr 2022 17:56:49 +0200
From:   Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Christoph Hellwig <hch@...radead.org>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [patch V5 3/3] smp: Make softirq handling RT safe in
 flush_smp_call_function_queue()

On 2022-04-13 15:31:05 [+0200], Thomas Gleixner wrote:
…
> +#ifdef CONFIG_PREEMPT_RT
> +extern void do_softirq_post_smp_call_flush(unsigned int was_pending);
> +#else
> +static inline void do_softirq_post_smp_call_flush(unsigned int unused)
> +{
> +	do_softirq();
> +}
> +#endif
> +
…
> +void softirq_post_smp_call_flush(unsigned int was_pending)
> +{
> +	if (WARN_ON_ONCE(was_pending != local_softirq_pending()))
> +		invoke_softirq();
> +}
> +
>  #else /* CONFIG_PREEMPT_RT */

fold, please.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
---
 kernel/softirq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/softirq.c b/kernel/softirq.c
index 1682586a69139..5b36ebe5e20de 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -301,7 +301,7 @@ static inline void invoke_softirq(void)
  * get raised which haven't been raised before the flush, warn so it can be
  * investigated.
  */
-void softirq_post_smp_call_flush(unsigned int was_pending)
+void do_softirq_post_smp_call_flush(unsigned int was_pending)
 {
 	if (WARN_ON_ONCE(was_pending != local_softirq_pending()))
 		invoke_softirq();

Sebastian