linux-kernel - Re: [PATCH] dmaengine: idxd: Fix the error handling path in idxd_cdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f3261912-dc13-46ed-471f-046ba314365d@intel.com>
Date:   Thu, 21 Apr 2022 08:34:19 -0700
From:   Dave Jiang <dave.jiang@...el.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Vinod Koul <vkoul@...nel.org>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        dmaengine@...r.kernel.org
Subject: Re: [PATCH] dmaengine: idxd: Fix the error handling path in
 idxd_cdev_register()


On 4/20/2022 11:13 PM, Christophe JAILLET wrote:
> If a call to alloc_chrdev_region() fails, the already allocated resources
> are leaking.
>
> Add the needed error handling path to fix the leak.
>
> Fixes: 42d279f9137a ("dmaengine: idxd: add char driver to expose submission portal to userland")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Acked-by: Dave Jiang <dave.jiang@...el.com>

Thanks!

> ---
>   drivers/dma/idxd/cdev.c | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/idxd/cdev.c b/drivers/dma/idxd/cdev.c
> index b9b2b4a4124e..033df43db0ce 100644
> --- a/drivers/dma/idxd/cdev.c
> +++ b/drivers/dma/idxd/cdev.c
> @@ -369,10 +369,16 @@ int idxd_cdev_register(void)
>   		rc = alloc_chrdev_region(&ictx[i].devt, 0, MINORMASK,
>   					 ictx[i].name);
>   		if (rc)
> -			return rc;
> +			goto err_free_chrdev_region;
>   	}
>   
>   	return 0;
> +
> +err_free_chrdev_region:
> +	for (i--; i >= 0; i--)
> +		unregister_chrdev_region(ictx[i].devt, MINORMASK);
> +
> +	return rc;
>   }
>   
>   void idxd_cdev_remove(void)