linux-kernel - Re: [PATCH] drm: bridge: dw_hdmi: Audio: fix returnvar.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b12c1e0c-7383-547d-b4ee-a9e60b2eea12@baylibre.com>
Date:   Thu, 21 Apr 2022 18:47:38 +0200
From:   Neil Armstrong <narmstrong@...libre.com>
To:     kernel test robot <lkp@...el.com>, Sandor Yu <Sandor.yu@....com>
Cc:     kbuild-all@...ts.01.org,
        Linux Memory Management List <linux-mm@...ck.org>,
        Robert Foss <robert.foss@...aro.org>,
        Shengjiu Wang <shengjiu.wang@....com>,
        Andrzej Hajda <andrzej.hajda@...el.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Jonas Karlman <jonas@...boo.se>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm: bridge: dw_hdmi: Audio: fix returnvar.cocci warnings

On 21/04/2022 17:09, kernel test robot wrote:
> From: kernel test robot <lkp@...el.com>
> 
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:80:5-8: Unneeded variable: "ret". Return "0" on line 94
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:105:5-8: Unneeded variable: "ret". Return "0" on line 112
> 
> 
>   Remove unneeded variable used to store return value.
> 
> Generated by: scripts/coccinelle/misc/returnvar.cocci
> 
> CC: Sandor Yu <Sandor.yu@....com>
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: kernel test robot <lkp@...el.com>
> ---
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   65eb92e4c9f0a962656f131521f4fbc0d24c9d4c
> commit: d970ce303ff80ae57bbd3e784f2772dbf3056e0c [4441/5346] drm: bridge: dw_hdmi: Audio: Add General Parallel Audio (GPA) driver
> :::::: branch date: 8 hours ago
> :::::: commit date: 2 days ago
> 
>   drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c |    6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c
> @@ -77,7 +77,6 @@ static int audio_hw_params(struct device
>   			   struct hdmi_codec_params *params)
>   {
>   	struct snd_dw_hdmi *dw = dev_get_drvdata(dev);
> -	int ret = 0;
>   	u8 ca;
>   
>   	dw_hdmi_set_sample_rate(dw->data.hdmi, params->sample_rate);
> @@ -91,7 +90,7 @@ static int audio_hw_params(struct device
>   				   params->iec.status[0] & IEC958_AES0_NONAUDIO);
>   	dw_hdmi_set_sample_width(dw->data.hdmi, params->sample_width);
>   
> -	return ret;
> +	return 0;
>   }
>   
>   static void audio_shutdown(struct device *dev, void *data)
> @@ -102,14 +101,13 @@ static int audio_mute_stream(struct devi
>   			     bool enable, int direction)
>   {
>   	struct snd_dw_hdmi *dw = dev_get_drvdata(dev);
> -	int ret = 0;
>   
>   	if (!enable)
>   		dw_hdmi_audio_enable(dw->data.hdmi);
>   	else
>   		dw_hdmi_audio_disable(dw->data.hdmi);
>   
> -	return ret;
> +	return 0;
>   }
>   
>   static int audio_get_eld(struct device *dev, void *data,

Reviewed-by: Neil Armstrong <narmstrong@...libre.com>