linux-kernel - RE: [EXT] [PATCH] drm: bridge: dw_hdmi: Audio: fix returnvar.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB7PR04MB545078BA054E5C78C5CCF9DBF4F79@DB7PR04MB5450.eurprd04.prod.outlook.com>
Date:   Fri, 22 Apr 2022 00:15:34 +0000
From:   Sandor Yu <sandor.yu@....com>
To:     kernel test robot <lkp@...el.com>
CC:     "kbuild-all@...ts.01.org" <kbuild-all@...ts.01.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        Robert Foss <robert.foss@...aro.org>,
        "S.J. Wang" <shengjiu.wang@....com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Andrzej Hajda <andrzej.hajda@...el.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Jonas Karlman <jonas@...boo.se>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXT] [PATCH] drm: bridge: dw_hdmi: Audio: fix returnvar.cocci
 warnings



> -----Original Message-----
> From: kernel test robot <lkp@...el.com>
> Sent: 2022年4月21日 23:10
> To: Sandor Yu <sandor.yu@....com>
> Cc: kbuild-all@...ts.01.org; Linux Memory Management List
> <linux-mm@...ck.org>; Robert Foss <robert.foss@...aro.org>; S.J. Wang
> <shengjiu.wang@....com>; Neil Armstrong <narmstrong@...libre.com>;
> Andrzej Hajda <andrzej.hajda@...el.com>; Laurent Pinchart
> <Laurent.pinchart@...asonboard.com>; Jonas Karlman <jonas@...boo.se>;
> Jernej Skrabec <jernej.skrabec@...il.com>; David Airlie <airlied@...ux.ie>;
> Daniel Vetter <daniel@...ll.ch>; dri-devel@...ts.freedesktop.org;
> linux-kernel@...r.kernel.org
> Subject: [EXT] [PATCH] drm: bridge: dw_hdmi: Audio: fix returnvar.cocci
> warnings
> 
> Caution: EXT Email
> 
> From: kernel test robot <lkp@...el.com>
> 
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:80:5-8: Unneeded
> variable: "ret". Return "0" on line 94
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:105:5-8: Unneeded
> variable: "ret". Return "0" on line 112
> 
> 
>  Remove unneeded variable used to store return value.
> 
> Generated by: scripts/coccinelle/misc/returnvar.cocci
> 
> CC: Sandor Yu <Sandor.yu@....com>
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: kernel test robot <lkp@...el.com>
> ---
> 
> tree:
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.ker
> nel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fnext%2Flinux-next.git&a
> mp;data=05%7C01%7CSandor.yu%40nxp.com%7C7028c89ce23940ff081408d
> a23a911c8%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637861
> 506299960569%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJ
> QIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&am
> p;sdata=P1pum2Ur3I8occ5f1WAnVhnIIGB0Q1HXc2GsRbUx8p0%3D&amp;res
> erved=0 master
> head:   65eb92e4c9f0a962656f131521f4fbc0d24c9d4c
> commit: d970ce303ff80ae57bbd3e784f2772dbf3056e0c [4441/5346] drm:
> bridge: dw_hdmi: Audio: Add General Parallel Audio (GPA) driver
> :::::: branch date: 8 hours ago
> :::::: commit date: 2 days ago
> 
>  drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c
> @@ -77,7 +77,6 @@ static int audio_hw_params(struct device
>                            struct hdmi_codec_params *params)  {
>         struct snd_dw_hdmi *dw = dev_get_drvdata(dev);
> -       int ret = 0;
>         u8 ca;
> 
>         dw_hdmi_set_sample_rate(dw->data.hdmi, params->sample_rate);
> @@ -91,7 +90,7 @@ static int audio_hw_params(struct device
>                                    params->iec.status[0] &
> IEC958_AES0_NONAUDIO);
>         dw_hdmi_set_sample_width(dw->data.hdmi,
> params->sample_width);
> 
> -       return ret;
> +       return 0;
>  }
> 
>  static void audio_shutdown(struct device *dev, void *data) @@ -102,14
> +101,13 @@ static int audio_mute_stream(struct devi
>                              bool enable, int direction)  {
>         struct snd_dw_hdmi *dw = dev_get_drvdata(dev);
> -       int ret = 0;
> 
>         if (!enable)
>                 dw_hdmi_audio_enable(dw->data.hdmi);
>         else
>                 dw_hdmi_audio_disable(dw->data.hdmi);
> 
> -       return ret;
> +       return 0;
>  }
> 
>  static int audio_get_eld(struct device *dev, void *data,

Reviewed-by: Sandor Yu <Sandor.yu@....com>