linux-kernel - Re: [PATCH V1] PCI/ASPM: Save/restore L1SS Capability for suspend/resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <42f9a28-e67-ec2a-f6-9a8b58edd84d@panix.com>
Date:   Thu, 21 Apr 2022 13:40:02 -0700 (PDT)
From:   "Kenneth R. Crudup" <kenny@...ix.com>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>
cc:     Bjorn Helgaas <helgaas@...nel.org>,
        Vidya Sagar <vidyas@...dia.com>, bhelgaas@...gle.com,
        lorenzo.pieralisi@....com, hkallweit1@...il.com,
        wangxiongfeng2@...wei.com, mika.westerberg@...ux.intel.com,
        chris.packham@...iedtelesis.co.nz, yangyicong@...ilicon.com,
        treding@...dia.com, jonathanh@...dia.com, abhsahu@...dia.com,
        sagupta@...dia.com, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, kthota@...dia.com,
        mmaddireddy@...dia.com, sagar.tv@...il.com,
        Ricky Wu <ricky_wu@...ltek.com>,
        Rajat Jain <rajatja@...gle.com>,
        Prasad Malisetty <quic_pmaliset@...cinc.com>,
        Victor Ding <victording@...gle.com>,
        "Kenneth R. Crudup" <kenny@...ix.com>
Subject: Re: [PATCH V1] PCI/ASPM: Save/restore L1SS Capability for
 suspend/resume


On Thu, 21 Apr 2022, Kai-Heng Feng wrote:

> I went through the whole discussion again, maybe Kenneth's case is
> also the result of pcie_aspm_pm_state_change()?

> Since Kenneth is using TLP to switch ASPM between performance and
> powersaving/powersupersaving, that means 'aspm_disabled' is false.
> Hence the KOXIA NVMe stops working post suspend and Realtek card
> reader toggles L1ss post hibernation.

> Kenneth, can you please see if removing pcie_aspm_pm_state_change()
> from pci_raw_set_power_state() helps?
> Anyway, this can be easier to spot if dmesg was attached.

Well, I haven't had an issue with resume/return from hibernate for quite some
time, and the patch I'd reported a long time ago is now in the Linus' master
I've been running. I believe a BIOS change from Dell fixed it up for me.

But if you're looking for information in any case, I could still do this and
get back to the topic re: the results.

	-Kenny

-- 
Kenneth R. Crudup / Sr. SW Engineer, Scott County Consulting, Orange County CA