linux-kernel - Re: [PATCH v2 08/12] md/raid5: Refactor for loop in raid5_make

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YmD21LQIUl4ahTTh@infradead.org>
Date:   Wed, 20 Apr 2022 23:16:52 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Logan Gunthorpe <logang@...tatee.com>
Cc:     linux-kernel@...r.kernel.org, linux-raid@...r.kernel.org,
        Song Liu <song@...nel.org>,
        Christoph Hellwig <hch@...radead.org>,
        Guoqing Jiang <guoqing.jiang@...ux.dev>,
        Stephen Bates <sbates@...thlin.com>,
        Martin Oliveira <Martin.Oliveira@...eticom.com>,
        David Sloan <David.Sloan@...eticom.com>
Subject: Re: [PATCH v2 08/12] md/raid5: Refactor for loop in
 raid5_make_request() into while loop

On Wed, Apr 20, 2022 at 01:54:21PM -0600, Logan Gunthorpe wrote:
>  	prepare_to_wait(&conf->wait_for_overlap, &w, TASK_UNINTERRUPTIBLE);
> -	for (; logical_sector < last_sector; logical_sector += RAID5_STRIPE_SECTORS(conf)) {
> -	retry:
> +	while (logical_sector < last_sector) {
>  		res = make_stripe_request(mddev, conf, &ctx, logical_sector,
>  					  bi);
>  		if (res == STRIPE_FAIL) {
>  			break;
>  		} else if (res == STRIPE_RETRY) {
> -			goto retry;
> +			continue;
>  		} else if (res == STRIPE_SCHEDULE_AND_RETRY) {
>  			schedule();
>  			prepare_to_wait(&conf->wait_for_overlap, &w,
>  					TASK_UNINTERRUPTIBLE);
> -			goto retry;
> +			continue;
>  		}

All the else statements here aren't needed (this is really a
comment for the earlier patch adding them).

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@....de>