linux-kernel - Re: [PATCH v2 2/2] mips: dts: ingenic: x1000: Add PWM device tree node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 22 Apr 2022 18:53:39 +0100
From:   Paul Cercueil <paul@...pouillou.net>
To:     Thierry Reding <thierry.reding@...il.com>
Cc:     Aidan MacDonald <aidanmacdonald.0x0@...il.com>, robh+dt@...nel.org,
        linux-mips@...r.kernel.org, devicetree@...r.kernel.org,
        linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Subject: Re: [PATCH v2 2/2] mips: dts: ingenic: x1000: Add PWM device tree
 node

Hi Thierry,

Le ven., avril 22 2022 at 18:12:05 +0200, Thierry Reding 
<thierry.reding@...il.com> a écrit :
> On Thu, Feb 24, 2022 at 11:41:34PM +0000, Aidan MacDonald wrote:
>>  Copied from the jz4740 devicetree and trimmed to 5 timers, which
>>  is what the hardware supports.
>> 
>>  Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@...il.com>
>>  ---
>>   arch/mips/boot/dts/ingenic/x1000.dtsi | 13 +++++++++++++
>>   1 file changed, 13 insertions(+)
> 
> However I don't see this upstream yet, neither in Linus' tree nor in
> linux-next. Paul, do you still have this on your radar?

I don't have a tree so that would be a patch for Thomas (Cc'd) to go 
through the linux-mips tree.
(Note to Thomas: patch 1 is already applied in the pwm tree)

The changes look good though, so:

Reviewed-by: Paul Cercueil <paul@...pouillou.net>

Cheers,
-Paul

> 
> Thierry
> 
>> 
>>  diff --git a/arch/mips/boot/dts/ingenic/x1000.dtsi 
>> b/arch/mips/boot/dts/ingenic/x1000.dtsi
>>  index 8bd27edef216..0dcf37527c8e 100644
>>  --- a/arch/mips/boot/dts/ingenic/x1000.dtsi
>>  +++ b/arch/mips/boot/dts/ingenic/x1000.dtsi
>>  @@ -127,6 +127,19 @@ wdt: watchdog@0 {
>>   			clocks = <&tcu TCU_CLK_WDT>;
>>   			clock-names = "wdt";
>>   		};
>>  +
>>  +		pwm: pwm@40 {
>>  +			compatible = "ingenic,x1000-pwm";
>>  +			reg = <0x40 0x80>;
>>  +
>>  +			#pwm-cells = <3>;
>>  +
>>  +			clocks = <&tcu TCU_CLK_TIMER0>, <&tcu TCU_CLK_TIMER1>,
>>  +				 <&tcu TCU_CLK_TIMER2>, <&tcu TCU_CLK_TIMER3>,
>>  +				 <&tcu TCU_CLK_TIMER4>;
>>  +			clock-names = "timer0", "timer1", "timer2",
>>  +				      "timer3", "timer4";
>>  +		};
>>   	};
>> 
>>   	rtc: rtc@...03000 {
>>  --
>>  2.34.1
>>