[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <5654205d-8829-6bca-f1be-0ef8e31dd0c0@wanyeetech.com>
Date: Sat, 23 Apr 2022 01:57:23 +0800
From: Zhou Yanjie <zhouyanjie@...yeetech.com>
To: Paul Cercueil <paul@...pouillou.net>
Cc: gregkh@...uxfoundation.org, hminas@...opsys.com,
robh+dt@...nel.org, krzk+dt@...nel.org, tsbogend@...ha.franken.de,
linux-usb@...r.kernel.org, linux-mips@...r.kernel.org,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
dongsheng.qiu@...enic.com, aric.pzqi@...enic.com,
rick.tyliu@...enic.com, sernia.zhou@...mail.com,
zhenwenjin@...il.com, reimu@...omaker.com
Subject: Re: [PATCH v4 1/3] dt-bindings: dwc2: Add bindings for new Ingenic
SoCs.
Hi Paul,
On 2022/4/22 下午8:44, Paul Cercueil wrote:
> Hi Zhou,
>
> Le ven., avril 22 2022 at 01:15:06 +0800, 周琰杰 (Zhou Yanjie)
> <zhouyanjie@...yeetech.com> a écrit :
>> Add the dwc2 bindings for the JZ4775 SoC, the JZ4780 SoC, the X1000 SoC,
>> the X1600 SoC, the X1830 SoC, and the X2000 SoC from Ingenic.
>>
>> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@...yeetech.com>
>> Acked-by: Rob Herring <robh@...nel.org>
>> ---
>>
>> Notes:
>> v1->v2:
>> Add Rob Herring's Acked-by.
>>
>> v2->v3:
>> No change.
>>
>> v3->v4:
>> Remove the compatible string of X1700 since it could use the
>> X1600 string
>> as the fallback.
>>
>> Documentation/devicetree/bindings/usb/dwc2.yaml | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml
>> b/Documentation/devicetree/bindings/usb/dwc2.yaml
>> index 4cebce6..2218df8 100644
>> --- a/Documentation/devicetree/bindings/usb/dwc2.yaml
>> +++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
>> @@ -17,6 +17,12 @@ properties:
>> oneOf:
>> - const: brcm,bcm2835-usb
>> - const: hisilicon,hi6220-usb
>> + - const: ingenic,jz4775-otg
>> + - const: ingenic,jz4780-otg
>> + - const: ingenic,x1000-otg
>> + - const: ingenic,x1600-otg
>> + - const: ingenic,x1830-otg
>> + - const: ingenic,x2000-otg
>
> You should probably also add:
> - items:
> - const: ingenic,x1700-otg
> - const: ingenic,x1600-otg
>
> As discussed in your v3.
Sure.
Thanks and best regards!
>
> Cheers,
> -Paul
>
>> - items:
>> - const: rockchip,rk3066-usb
>> - const: snps,dwc2
>> --
>> 2.7.4
>>
>
Powered by blists - more mailing lists