linux-kernel - Re: [PATCH v3 3/3] fat: report creation time in statx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87o80tpbjh.fsf@mail.parknet.co.jp>
Date:   Fri, 22 Apr 2022 21:06:42 +0900
From:   OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:     Chung-Chiang Cheng <shepjeng@...il.com>
Cc:     Chung-Chiang Cheng <cccheng@...ology.com>,
        linux-kernel@...r.kernel.org, kernel@...heng.net
Subject: Re: [PATCH v3 3/3] fat: report creation time in statx

Chung-Chiang Cheng <shepjeng@...il.com> writes:

>
> I also have a question. If msdos doesn't support create-time, why does the
> original fat_truncate_time() truncate it to a 2-sec granularity?
>
> if (flags & S_CTIME) {
>         if (sbi->options.isvfat)
>                 inode->i_ctime = fat_timespec64_trunc_10ms(*now);
>         else
>                 inode->i_ctime = fat_timespec64_trunc_2secs(*now);
> }
>
> This logic was introduced in 6bb885ecd746 (fat: add functions to update
> and truncate timestamps appropriately"), and seems not for change-time.
> Should I remove it?

Hm, not sure.

However, ctime/atime is not stored into backing storage in
__fat_write_inode() and loaded if !isvfat (if I'm not missing
something).  So I think we don't need it for creation time.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>