linux-kernel - Re: [PATCH v2 1/2] dt-bindings: clock: Add Qualcomm SC8280XP GCC bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220423031350.01299C385A0@smtp.kernel.org>
Date:   Fri, 22 Apr 2022 20:13:48 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Michael Turquette <mturquette@...libre.com>,
        Rob Herring <robh+dt@...nel.org>,
        linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        quic_tdas@...cinc.com
Subject: Re: [PATCH v2 1/2] dt-bindings: clock: Add Qualcomm SC8280XP GCC bindings

Quoting Bjorn Andersson (2022-04-22 20:02:57)
> On Fri 22 Apr 18:48 PDT 2022, Stephen Boyd wrote:
> 
> > Quoting Bjorn Andersson (2022-04-22 16:00:12)
> > > Add binding for the Qualcomm SC8280XP Global Clock controller.
> > > 
> > > Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> > 
> > Why no cover letter?
> > 
> 
> I didn't have anything useful to write in it. Will provide you one in
> the future...

Thanks!

> > > +  clocks:
> > > +    items:
> > > +      - description: XO reference clock
> > 
> > "clock" is redundant in all these descriptions. Please remove.
> > 
> 
> You don't think it's a little bit odd to have description such as
> "Sleep", "PCIe 2a pipe" or First EMAC controller reference"?
> 
> I mean I agree that it's obviously clocks we're talking about, but to me
> that makes it seems like the descriptions are cut short, just for the
> sake of avoiding "clock".

Alright, keeping clock is OK as long as

> 
> > > +      - description: Sleep clock
> > > +      - description: UFS memory first RX symbol clock
> > > +      - description: UFS memory second RX symbol clock
> > > +      - description: UFS memory first TX symbol clock
> > > +      - description: UFS card first RX symbol clock
> > > +      - description: UFS card second RX symbol clock
> > > +      - description: UFS card first TX symbol clock
> > > +      - description: Primary USB SuperSpeed pipe clock
> > > +      - description: gcc_usb4_phy_pipegmux_clk_src

there is a better name for this and the other non-word descriptions.

USB4 phy pipe gmux clock source?

> > > +      - description: gcc_usb4_phy_dp_gmux_clk_src
> > > +      - description: gcc_usb4_phy_sys_pipegmux_clk_src
> > > +      - description: usb4_phy_gcc_usb4_pcie_pipe_clk
> > > +      - description: usb4_phy_gcc_usb4rtr_max_pipe_clk
> > > +      - description: Primary USB4 RX0 clock
> > > +      - description: Primary USB4 RX1 clock
> > > +      - description: Secondary USB SuperSpeed pipe clock
> > > +      - description: gcc_usb4_1_phy_pipegmux_clk_src
> > > +      - description: gcc_usb4_1_phy_dp_gmux_clk_src
> > > +      - description: gcc_usb4_1_phy_sys_pipegmux_clk_src
> > > +      - description: usb4_1_phy_gcc_usb4_pcie_pipe_clk
> > > +      - description: usb4_1_phy_gcc_usb4rtr_max_pipe_clk
> > > +      - description: Secondary USB4 RX0 clock
> > > +      - description: Secondary USB4 RX0 clock
> > > +      - description: Multiport USB first SupserSpeed pipe clock
> > > +      - description: Multiport USB second SuperSpeed pipe clock
> > > +      - description: PCIe 2a pipe clock
> > > +      - description: PCIe 2b pipe clock
> > > +      - description: PCIe 3a pipe clock
> > > +      - description: PCIe 3b pipe clock
> > > +      - description: PCIe 4 pipe clock
> > > +      - description: First EMAC controller reference clock
> > > +      - description: Second EMAC controller reference clock
> > > +
> > > +  clock-names:
> > > +    items:
> > > +      - const: bi_tcxo
> > > +      - const: sleep_clk
> > 
> > And "_clk" postfix is redundant in all these strings. Remove?
> > 
> 
> In this case I think they should include _clk, as they actually matches
> the clock names in the documentation.
> 

I'd really rather not have clock-names at all because we spend a bunch
of time comparing strings with them when we could just as easily use
a number.