linux-kernel - Re: clang-format inconsistencies with checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72nLOfmEt-CZBmm2ouEB_x6Jm9ggDVFCVJxYxKw7O0LTzQ@mail.gmail.com>
Date:   Sat, 23 Apr 2022 18:14:48 +0200
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Mickaël Salaün <mic@...ikod.net>
Cc:     Miguel Ojeda <ojeda@...nel.org>,
        Andy Whitcroft <apw@...onical.com>,
        Joe Perches <joe@...ches.com>,
        Dwaipayan Ray <dwaipayanray1@...il.com>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Tom Rix <trix@...hat.com>, llvm@...ts.linux.dev,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: clang-format inconsistencies with checkpatch.pl

Hi Mickaël,

On Sat, Apr 23, 2022 at 1:45 PM Mickaël Salaün <mic@...ikod.net> wrote:
>
> I also noticed that there is some clang-format configuration lines that
> are commented because of incompatibilities with versions older than 6.
> Shouldn't we require a minimal version, at least the 6th?

I will be increasing this cycle the version to 11, which is the
minimum LLVM supported at the moment, and then keep it sync'd to that
minimum.

> About checkpatch.pl, it incorrectly warns about space between function
> name and open parenthesis for *for_each* functions (specifically
> interpreted as "for" statements in .clang-format, e.g. list_for_each_entry).

Note that the prevailing kernel style is to not have a space. This
should be fixed with the increase to 11.

Cheers,
Miguel